Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix PSK value issue related to #109 #388

Merged
merged 1 commit into from
May 29, 2021

Conversation

ericsysmin
Copy link
Contributor

SUMMARY

Fixes #109 by changing the value to lowercase.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zabbix_proxy role

ADDITIONAL INFORMATION

Before fix Zabbix Proxy would fail to start

TASK [community.zabbix.zabbix_proxy : zabbix-proxy started] ****************************************************************************************
fatal: [hostname]: FAILED! => {"changed": false, "msg": "Unable to start service zabbix-proxy: Job for zabbix-proxy.service failed because the control process exited with error code.\nSee \"systemctl status zabbix-proxy.service\" and \"journalctl -xe\" for details.\n"}

May 28 07:14:17 hostname zabbix_proxy[29974]: zabbix_proxy [29974]: ERROR: invalid value of "TLSAccept" parameter
May 28 07:14:17 hostname systemd[1]: zabbix-proxy.service: Control process exited, code=exited status=1
May 28 07:14:17 hostname systemd[1]: zabbix-proxy.service: Failed with result 'exit-code'.
May 28 07:14:17 hostname systemd[1]: Failed to start Zabbix Proxy.
-- Subject: Unit zabbix-proxy.service has failed

After the change

TASK [community.zabbix.zabbix_proxy : zabbix-proxy started] ****************************************************************************************
ok: [hostname]


 zabbix-proxy.service - Zabbix Proxy
   Loaded: loaded (/lib/systemd/system/zabbix-proxy.service; enabled; vendor preset: enabled)
   Active: active (running) since Fri 2021-05-28 16:55:18 UTC; 3min 7s ago
  Process: 2419 ExecStart=/usr/sbin/zabbix_proxy -c $CONFFILE (code=exited, status=0/SUCCESS)
 Main PID: 2439 (zabbix_proxy)

@ericsysmin ericsysmin changed the title Fix bug causing issue #109 Bug Fix PSK value issue related to #109 May 28, 2021
@ericsysmin
Copy link
Contributor Author

@D3DeFi can you review?

Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please put changelog snippet into the PR?

otherwise I think this is good to go and long overdue anyway. It just slipped our attention a while back. I can confirm it will work like this when calling zabbix_proxy module.

Not sure what else it will break tho
@dj-wasabi can you please also confirm this is good to go and will not have some other consequences?

@D3DeFi D3DeFi requested a review from dj-wasabi May 28, 2021 20:29
Copy link
Contributor

@dj-wasabi dj-wasabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@D3DeFi D3DeFi merged commit 8e16c21 into ansible-collections:main May 29, 2021
@D3DeFi
Copy link
Contributor

D3DeFi commented May 29, 2021

I will be passing all of the PRs when releasing 1.4.0 this weekend and fill in missing changelogs

@ericsysmin
Copy link
Contributor Author

Ok, ya, it got merged before I had time to fill out a changelog but the change was simple enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zabbix_proxy role: zabbix_proxy_tls_config default not mapped from config to API
3 participants