Fix error handling in creation of service account keys #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When creating a service account key with the
google.cloud.gcp_iam_service_account_keymodule, when theservice_account.namewas incorrect, the404error was improperly interpreted as normal business, and resulted in a cryptic stacktrace. Plus, thegcp_iam_service_account_keymodule had no integration test at all.Here we fix the above issue and we add proper integration test cases.
Fixes: #244
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
This affects the
google.cloud.gcp_iam_service_account_keymodule only.ADDITIONAL INFORMATION
Passing tests:
ansible-test integration "gcp_iam_service_account_key".