Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand template instructions in 'token' property #49

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Expand template instructions in 'token' property #49

merged 1 commit into from
Apr 7, 2021

Conversation

tofi86
Copy link
Contributor

@tofi86 tofi86 commented Jan 28, 2021

SUMMARY

This change passes the token property through the jinja templating engine so that the token can for example be retrieved via a lookup plugin (password store, etc.).

Fixes #48

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hcloud inventory_plugin

ADDITIONAL INFORMATION

@tofi86 tofi86 mentioned this pull request Jan 28, 2021
Closed
@ieugen
Copy link

ieugen commented Feb 24, 2021

I think this is exactly what I need for #61 .
Looking forward for this. Any ETA on when it's going to be published?

Base automatically changed from master to main March 26, 2021 09:04
@ieugen
Copy link

ieugen commented Mar 30, 2021

@LKaemmerling / anyone: Any chances we can get this merged and released?

resmo
resmo reviewed Apr 6, 2021
View reviewed changes
plugins/inventory/hcloud.py Outdated Show resolved Hide resolved
@tofi86
Copy link
Contributor Author

tofi86 commented Apr 6, 2021 •
edited
Loading

because of the or os.getenv shouldn't this be fail_on_undefined=False?

Rebased on current main, edited to fail_on_undefined=False and force-pushed to my feature-branch – thus updating this PR.

@tofi86 tofi86 requested a review from resmo April 6, 2021 21:30
@LKaemmerling LKaemmerling merged commit a393f4e into ansible-collections:main Apr 7, 2021
@LKaemmerling
Copy link
Collaborator

Thank you! Good job :)

@tofi86 tofi86 deleted the tofi86-patch-1 branch April 7, 2021 07:39
@tofi86
Copy link
Contributor Author

tofi86 commented Apr 7, 2021

Thanks! ☺️ You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@resmo resmo Awaiting requested review from resmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support lookup() plugins for token retrieval
5 participants
@tofi86 @ieugen @LKaemmerling @resmo @felixfontein