Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Update README.rst #82

Merged
merged 4 commits into from Jul 29, 2020
Merged

WIP Update README.rst #82

merged 4 commits into from Jul 29, 2020

Conversation

gundalow
Copy link
Contributor

@gundalow gundalow commented Jun 1, 2020 •
edited

  • s/future/past tense/g
  • mention ACD as that term has been used, though make it clear that's not a term we should be using anymore
  • Make it clear about packages (reference ansible-build-data/blob/master/2.10/acd.in)
  • for ansible-base definition, make it clear you may want to use that along side specific collections
  • Update links to pre-release builds of ansible Python package
  • Maybe mention antsibull
SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

jamescassell
jamescassell requested changes Jun 1, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@gundalow gundalow changed the title Update README.rst WIP Update README.rst Jun 1, 2020
@gundalow gundalow marked this pull request as draft June 1, 2020 18:48
@gundalow gundalow marked this pull request as ready for review June 18, 2020 20:58
felixfontein
felixfontein reviewed Jun 24, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@felixfontein felixfontein mentioned this pull request Jul 15, 2020
Closed
gundalow and others added 2 commits July 29, 2020 20:12
@gundalow @felixfontein
Update README.rst
7f858c7 
s/future/past tense/g


1) mention ACD as that term has been used, though make it clear that's not a term we should be using anymore
2) Make it clear about packages (reference ansible-build-data/blob/master/2.10/acd.in)
3) for ansible-base definition, make it clear you may want to use that along side specific collections
4) Update links to pre-release builds of `ansible` Python package
5) Maybe mention antsibull
@gundalow @jamescassell @felixfontein
Apply suggestions from code review
0833218 
Co-authored-by: James Cassell <code@james.cassell.me>
@abadger
Copy link
Contributor

abadger commented Jul 29, 2020

+1 to merge from me once rebased.

@felixfontein felixfontein merged commit debf901 into master Jul 29, 2020
@felixfontein felixfontein deleted the gundalow/readme branch July 29, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@jamescassell jamescassell jamescassell requested changes

Assignees
No one assigned
Labels
None yet
Projects
Community Plan v2
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gundalow @abadger @jamescassell @felixfontein