Refactor build-release role tests.yml #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxwell G <gotmax@e.email>
Signed-off-by: Maxwell G <gotmax@e.email>
Automated with https://github.com/CentOS/infra-scripts/blob/master/ansible/convert-ansible-tasks-to-fqcn Signed-off-by: Maxwell G <gotmax@e.email>
There was a problem hiding this comment.
Thanks for your contribution! Would you mind adding a changelog fragment? Thanks.
roles/build-release/vars/main.yml
Outdated
Comment on lines
6
to
9
| antsibull_pip_bin: "{{ antsibull_ansible_venv }}/bin/pip" | ||
| antsibull_pip_pkgs: "{{ _pip_pkgs['packages'][antsibull_pip_bin] }}" | ||
| ansible_version_pypi: "{{ antsibull_pip_pkgs['ansible'][0]['version'] }}" | ||
| _installed_ansible_core: "{{ antsibull_pip_pkgs['ansible-core'][0]['version'] }}" |
There was a problem hiding this comment.
How about always using the prefix antsibull_ansible_venv for everything that's in antsibull's ansible venv?
Suggested change
| antsibull_pip_bin: "{{ antsibull_ansible_venv }}/bin/pip" | |
| antsibull_pip_pkgs: "{{ _pip_pkgs['packages'][antsibull_pip_bin] }}" | |
| ansible_version_pypi: "{{ antsibull_pip_pkgs['ansible'][0]['version'] }}" | |
| _installed_ansible_core: "{{ antsibull_pip_pkgs['ansible-core'][0]['version'] }}" | |
| antsibull_ansible_venv_pip_bin: "{{ antsibull_ansible_venv }}/bin/pip" | |
| antsibull_ansible_venv_pip_pkgs: "{{ _pip_pkgs['packages'][antsibull_pip_bin] }}" | |
| antsibull_ansible_venv_installed_ansible_version: "{{ antsibull_pip_pkgs['ansible'][0]['version'] }}" | |
| antsibull_ansible_venv_installed_ansible_core_version: "{{ antsibull_pip_pkgs['ansible-core'][0]['version'] }}" |
There was a problem hiding this comment.
Maybe antsibull_venv? I dislike the long variable names.
There was a problem hiding this comment.
Fine for me. @dmsimard what do you think?
I've added a changelog fragment. I've never written an ansible changelog fragment before, so let me know if it needs any changes :). |
gotmax23
force-pushed
the
build_release_test_refactor
branch
from
db7de56
to
028b35f
Compare
gotmax23
commented
Jun 24, 2022
changelogs/fragments/432-build-release-role-minor-refactoring.yml
Outdated
Show resolved
Hide resolved
gotmax23
force-pushed
the
build_release_test_refactor
branch
2 times, most recently
from
0c431fd
to
9eff261
Compare
Signed-off-by: Maxwell G <gotmax@e.email>
Signed-off-by: Maxwell G <gotmax@e.email> Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Maxwell G <gotmax@e.email>
gotmax23
force-pushed
the
build_release_test_refactor
branch
from
9eff261
to
70cfc21
Compare
felixfontein
reviewed
Jul 4, 2022
changelogs/fragments/432-build-release-role-minor-refactoring.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxwell G <gotmax@e.email>
Signed-off-by: Maxwell G <gotmax@e.email>
gotmax23
force-pushed
the
build_release_test_refactor
branch
from
70cfc21
to
f3a9eaf
Compare
felixfontein
approved these changes
Jul 4, 2022
|
@gotmax23 thanks for contributing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ompragash inspired me to look into how ansible is actually released, and I noticed some opportunities for improvement. Hopefully, this is helpful. At least, it has provided me with a distraction from my other work :).