-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintenance: update & fix CI, bump python >=3.8, bump postgresql >= 12 #71
Conversation
dmsimard
commented
Feb 6, 2024
- Bump Fedora 36 to 39
- Use cloud images for centos stream 8 and 9
- Bump Fedora 36 to 39 - Use cloud images for centos stream 8 and 9
Build failed. ❌ ara-role-api-distributed-sqlite FAILURE in 9m 56s |
recheck |
Zuul encountered a syntax error while parsing its configuration in the Nodeset ara-fedora-39 already defined in project ansible-community/ara The error appears in the following nodeset stanza: nodeset: in "ansible-community/ara-collection/.zuul.d/nodesets.yaml@master", line 50, column 3 |
It's already defined in ansible-community/ara
Build failed. ❌ ara-role-api-distributed-sqlite FAILURE in 10m 40s |
There's now a failure about the python version of centos stream 8: This should be addressed by this PR from @Thulium-Drake: #70 I will cherry-pick it here in the interest of trying to fix every job before merging this one PR. |
Build failed. ✔️ ara-role-api-distributed-sqlite SUCCESS in 11m 20s |
re: postgresql, this is as a result of bumping django up to the latest LTS (4.2) in ara 1.7.0: https://docs.djangoproject.com/en/5.0/releases/4.2/#dropped-support-for-postgresql-11 |
Build failed. ✔️ ara-role-api-distributed-sqlite SUCCESS in 9m 40s |
Build succeeded. ✔️ ara-role-api-distributed-sqlite SUCCESS in 8m 52s |
We need the development dependencies to install database backend packages with pip.
django 4.2 requires postgresql 12 and above.
It works! I've squashed/cleaned up commits and I'll merge this soon. @Thulium-Drake @hille721: FYI if you would like to look. We'll be able to close #70 and start looking at the other PRs which we'll need to rebase on top of latest master so they have those fixes. |
Build failed. ❌ ara-role-api-distributed-sqlite FAILURE in 26m 51s |
It looks like the jobs may be race-y due to the nature of running multiple nodes, let me try that again. |
recheck |
Build failed. ❌ ara-role-api-distributed-sqlite FAILURE in 9m 04s |
There are some assumptions in ara's integration tests (like this one) that assume the test playbook is only ran once from localhost but here we have multiple nodes running concurrently (centos stream 8, 9 and fedora 39) in order to parallelize the test coverage across multiple distros. That's where we would add the debian/ubuntu nodes if we had them. We could fix the assumptions in the tests but I expect it is possible to continue running into "interesting" concurrency issues. I need some time to think about the best approach that would be reliable and allow for the inclusion of debian and ubuntu. |
Would it be a start, at least for now, to drop the parallel testing of multiple ARA instances? I really can't think of a scenario where that's used, unless I'm missing something. Do you? Also, how much I like (and run!) Debian, I think that's easier to add later and test when CI is alive again :-) |
Once upon a time, the idea was to test multiple distros inside a single job (instead of one job per distro) but we can do it the other way around, too. We've migrated around different Zuul instances over the years and now we have a more constrained set of images to work with: https://ansible.softwarefactory-project.io/zuul/labels
Yes, I want to be able to test the distros that the collection pretends supporting :p |
recheck |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
ara bumped the version of django to 4.2 allowing us to unpin psycopg2.
Not sure why that Zuul failure occurred, the repo has not moved. Amended last commit to trgger a new run. |
Build succeeded. ✔️ ara-role-api-distributed-sqlite SUCCESS in 9m 34s |
🚀 Zuul's happy! Can we merge this? I'm starting to run into some issues for which there's already some PRs out :-) I'll happily integrate them when this is merged |
Yes, this has been dragging on for too long. We can address the Zuul flappiness later. Let's do it. |