Debian 12 support #68
Conversation
* support using system packages in installation venv * changed version pinning of psycopg2 to reflect the comment * updated package dependencies for Debian 12 Tested with pypi installation method, postgresql backend using Debian's package python3-psycopg2 (version 2.9.5-1+b1).
|
Build succeeded. ✔️ ara-role-api-distributed-sqlite SUCCESS in 13m 09s |
|
Looks good, the whole "Debian 12, Python 3.11, thou shalt not install pip packages outside of pipx" prompted me to make #69, but good to see there's options now ;-) @dmsimard maybe drop testing for Ubuntu and switch to Debian instead? I have my environment running on it, but it seems more people do :-) |
|
Using a venv still seems to be a valid way for Debian 12. But I did not see a real advantage in using pipx instead of pip, so I tried not to make too many changes. |
|
Hello, sorry for the delay and thanks for the PR! I've actually just recently used the collection to deploy on top of Debian 12, I had filed these issues but you beat me to sending a PR:
This looks good at first glance but I will review it sometime soon. |
At this time this is dependant on Debian being available in Zuul (which it isn't). That's not to say we couldn't do it via a github action or something like that but it's probably a bigger discussion to have. |
|
Any updates on this? |
|
I will have an opportunity to test this soon, it will be included in an upcoming bugfix release. |
|
The opportunity is here and I am working my way through this. Sorry it's taken so long. For context I will be migrating the existing live demo (https://demo.recordsansible.org/) to Debian 12 and it is already set up to use the collection with https://github.com/ansible-community/ara-infra/blob/master/playbooks/live-demo.yaml. It's historically been deployed to CentOS but I'll use the collection to redeploy it. |
| @@ -42,7 +42,7 @@ | |||
| pip: | |||
| # Pin psycopg2 until we upgrade to django 3.2 LTS | |||
| # https://github.com/ansible-community/ara/issues/320 | |||
| name: psycopg2<2.9 | |||
| name: psycopg2<3 | |||
There was a problem hiding this comment.
This made me go down quite a rabbithole -- django is currently allowed to be up to 4.2 which is the latest LTS: https://github.com/ansible-community/ara/blob/8eda9c87086a289cf9bf41a2d4cc4060e2d50ad7/setup.cfg#L67-L69
I suppose we are past April 2024 so we could bump the version of django to 4.2 and figure out whether we can use psycopg3. I will not go down this hole just yet but I'll make sure <3 works.
There was a problem hiding this comment.
To be clear, we removed the pinning on psycopg2 in a separate patch here: 7dc61fe
I checked and the last version is currently 2.9.9:
Pinning it to <3 seems fair and it looks like a ❤️
Tested with pypi installation method, postgresql backend using Debian's package python3-psycopg2 (version 2.9.5-1+b1).