Skip to content

Commit

Permalink
UI: fix links to file line anchors
Browse files Browse the repository at this point in the history
The anchor is "#line-<number>", not just "#<number>" so the link to the
line was broken. The link works now.

The line isn't highlighted but it's another problem, see related issue.

Change-Id: I005517c80df8159621dc431102231c301757ebdd
Related: #154
  • Loading branch information
dmsimard committed Aug 29, 2020
1 parent 41b307e commit bdb8974
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ara/ui/templates/playbook.html
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
<a href="../results/{{ result.id }}.html">{{ task.name }}</a>
</td>
<td role="cell" data-label="Action" class="pf-m-fit-content">
<a href="../files/{{ task.file.id }}.html#{{ task.lineno }}">{{ task.action }}</a>
<a href="../files/{{ task.file.id }}.html#line-{{ task.lineno }}">{{ task.action }}</a>
</td>
<td role="cell" data-label="Duration" class="pf-m-fit-content">
{{ result.duration | format_duration }}
Expand Down
2 changes: 1 addition & 1 deletion ara/ui/templates/result.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h1><strong>Details</strong></h1>
<ul class="pf-c-list">
<li><strong>Task</strong>: {{ result.task.name }}</a></li>
<li><strong>Action</strong>: {{ result.task.action }}</li>
<li><strong>Path</strong>: <a href="../files/{{ result.task.file }}.html#{{ result.task.lineno }}">{{ result.task.path }}:{{ result.task.lineno }}</a>
<li><strong>Path</strong>: <a href="../files/{{ result.task.file }}.html#line-{{ result.task.lineno }}">{{ result.task.path }}:{{ result.task.lineno }}</a>
<li><strong>Host</strong>: <a href="../hosts/{{ result.host.id }}.html">{{ result.host.name }}</a></li>
<li><strong>Status</strong>: {{ result.status }}</li>
<li><strong>Started</strong>: {{ result.started | format_date }}</li>
Expand Down

0 comments on commit bdb8974

Please sign in to comment.