Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Linking to a line number in a file doesn't highlight the line #154

Closed
dmsimard opened this issue Aug 13, 2020 · 5 comments
Closed

UI: Linking to a line number in a file doesn't highlight the line #154

dmsimard opened this issue Aug 13, 2020 · 5 comments
Labels
bug UI Related to the built-in user interface

Comments

@dmsimard
Copy link
Contributor

What component is this about ?

The built-in reporting interface

What is happening ?

When clicking on a link to a file with a line anchor (i.e: https://server/file/123.html#line-10), the line isn't highlighted like it was in 0.x.

What should be happening ?

It should work.
@dmsimard
Copy link
Contributor Author

WIP here: https://review.opendev.org/#/c/731999/

@dmsimard dmsimard added this to the 1.5 milestone Aug 13, 2020
@dmsimard dmsimard added bug UI Related to the built-in user interface labels Aug 18, 2020
arecordsansible pushed a commit that referenced this issue Aug 29, 2020
@dmsimard
UI: fix links to file line anchors
bdb8974 
The anchor is "#line-<number>", not just "#<number>" so the link to the
line was broken. The link works now.

The line isn't highlighted but it's another problem, see related issue.

Change-Id: I005517c80df8159621dc431102231c301757ebdd
Related: #154
@dmsimard
Copy link
Contributor Author

Will be fixed and released in 1.5.

@dmsimard
Copy link
Contributor Author

wait -- scratch that, this is about the line being highlighted.
I thought it was about the line anchor which got fixed in bdb8974

@dmsimard dmsimard reopened this Sep 16, 2020
@dmsimard
Copy link
Contributor Author

Sorry, I'm going to delay this until after 1.5 -- there is at least a fix for the link anchor, we'll fix the highlight later which can easily be in a dot release.

@dmsimard dmsimard removed this from the 1.5 milestone Sep 16, 2020
@dmsimard
Copy link
Contributor Author

This will land in 1.5.6 \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug UI Related to the built-in user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmsimard