Fixes podman always remove existing containers

[juanvalino]

Fixes: #186

[oukooveu]

Could someone review this please?

[juanvalino]

This bug makes molecule unusable with podman, could someone review the fix I submitted please?

[oukooveu]

@ssbarnea could you please help with this PR?

[zhan9san]

@juanvalino

Thanks for your contribution.

I recommend to use podman_container_module to manage the podman container, which is idempotent. And molecule-docker are also using Ansible collection module to manage the docker container.

https://docs.ansible.com/ansible/latest/collections/containers/podman/podman_container_module.html#ansible-collections-containers-podman-podman-container-module

Here is what I tested

- name: nginx
  hosts: localhost

  tasks:
    - name: Create a Nginx container
      containers.podman.podman_container:
        name: nginx
        image: nginx
        state: started

1. Start a container via podman_container module

❯ ansible-playbook -i inventory.yaml test-playbook.yml

PLAY [nginx] ***************************************************************************************************************************

TASK [Gathering Facts] *****************************************************************************************************************
ok: [localhost]

TASK [Create a Nginx container] ********************************************************************************************************
changed: [localhost]

PLAY RECAP *****************************************************************************************************************************
localhost               : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

x@v:~$ podman stop nginx
nginx

3. Start the container via podman_container again

❯ ansible-playbook -i inventory.yaml test-playbook.yml

PLAY [nginx] ***************************************************************************************************************************

TASK [Gathering Facts] *****************************************************************************************************************
ok: [localhost]

TASK [Create a Nginx container] ********************************************************************************************************
changed: [localhost]

PLAY RECAP *****************************************************************************************************************************
localhost               : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

4. Check the nginx container

x@v:~$ podman ps
CONTAINER ID  IMAGE                           COMMAND               CREATED         STATUS            PORTS       NAMES
461be2095731  docker.io/library/nginx:latest  nginx -g daemon o...  40 minutes ago  Up 3 minutes ago              nginx

[juanvalino]

@zhan9san do you want me to send a new version of the patch replacing command calls by podman_container_module ?

[zhan9san]

@juanvalino

Yes. Do you have any concern?

[juanvalino]

No concern @zhan9san. I'll try to cleanup all command calls replacing them by podman ansible modules.

[juanvalino]

@zhan9san I have updated my pull request refactoring the full podman create.yml to eliminate all direct calls to command module. I need your help to fix some of checks that are failing.

[oukooveu]

@juanvalino are you sure latest version resolves initial issue? in my case container is recreated on each converge run.

[zhan9san]

@oukooveu
This PR is to fix the issue described in the title.

If the container is managed by podman collection, it would not recreate the container.
Do you have any concern?

[oukooveu]

@oukooveu This PR is to fix the issue described in the title.

If the container is managed by podman collection, it would not recreate the container. Do you have any concern?

There are no concerns, but in my case this is not working as expected (with latest patch) and container is recreated each converge run. With initial approach, the issue was solved.

[zhan9san]

Hi @oukooveu

Could you please show me how do you run the test?

I tested it with this change and it works as expected and no new container is created.

pip uninstall molecule-plugins
git clone https://github.com/juanvalino/molecule-plugins.git
cd molecule-plugins
pip install -e .

[juanvalino]

@oukooveu I've tested using the procedure given by @zhan9san and seems to work for me

[zhan9san]

@juanvalino

LGTM
Thanks for your great work.