Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: remove ansible_async_dir setting logic #182

Merged
merged 1 commit into from Nov 14, 2023
Merged

podman: remove ansible_async_dir setting logic #182

merged 1 commit into from Nov 14, 2023

Conversation

grcancelliere
Copy link
Contributor

@grcancelliere grcancelliere commented Aug 4, 2023 •
edited

fixes #181

b5509a1 uses $USER to get the home for the current user, but if the controller does not run login(1), like in containers, the variable is not set. This PR uses whoami to get the current user.

EDIT Since the ansible_async_dir setting logic is not needed anymore (see #182 (comment)) this PR now removes it in create.yml and destroy.yml.

@grcancelliere grcancelliere force-pushed the avoid-hardcoding-ansible-async-dir-without-user branch 4 times, most recently from 23f311d to a807707 Compare August 4, 2023 09:04
@grcancelliere grcancelliere marked this pull request as ready for review August 4, 2023 09:15
@zhan9san zhan9san added the bug Something isn't working label Aug 16, 2023
@grcancelliere
Copy link
Contributor Author

@zhan9san since ansible.builtin.getent is not supported on OS X (#183) I was thinking about replacing it with a call to ansible.builtin.user with state: present to get the POSIX home without duplicating the logic. What do you prefer, a new commit, editing this commit or creating another PR?

@zhan9san
Copy link
Member

@grcancelliere

Could you please remove the logic of setting ansible_async_dir?

This magic is introduced in ansible-community/molecule-podman#139

The ~ and HOME has been the same in latest creater-ee image, in ansible/creator-ee#19 (comment).

$ docker run -it quay.io/ansible/creator-ee:latest /bin/bash
# echo $HOME
/home/runner
root@creator-ee:v0.21.0: /tmp
# echo ~root
/home/runner
root@creator-ee:v0.21.0: /tmp
# echo ~
/home/runner
root@creator-ee:v0.21.0: /tmp
# echo $HOME
/home/runner

Let me know if you have any concern @ssbarnea

@grcancelliere
Copy link
Contributor Author

@zhan9san Sure, i'll change the PR this week. Thanks for the links.

@grcancelliere grcancelliere marked this pull request as draft November 13, 2023 10:46
@zhan9san zhan9san mentioned this pull request Nov 14, 2023
Closed
@grcancelliere
podman: remove ansible_async_dir from create.yml and destroy.yml
fc4359b 
b5509a1 uses $USER to get the home for the current user, but
if the controller does not run login(1), like in containers, the variable is not set.
Since the original bug that needed ansible_async_dir was fixed (see ansible-community/molecule-podman PR ansible-community#139 and ansible/creator-ee#19),
remove all the related changes.

- src/molecule_plugins/podman/playbooks: remove ansible_async_dir tasks from create.yml and destroy.yml
- tox.ini: remove USER from the pass_env list
@grcancelliere grcancelliere force-pushed the avoid-hardcoding-ansible-async-dir-without-user branch from a807707 to fc4359b Compare November 14, 2023 06:35
@grcancelliere grcancelliere marked this pull request as ready for review November 14, 2023 06:47
@zhan9san zhan9san changed the title podman: get the current user from whoami instead of the environment podman: remove ansible_async_dir setting logic Nov 14, 2023
@zhan9san zhan9san merged commit 0244719 into ansible-community:main Nov 14, 2023
10 checks passed
@zhan9san
Copy link
Member

@grcancelliere

Thanks for your contribution. You are doing great

@grcancelliere grcancelliere deleted the avoid-hardcoding-ansible-async-dir-without-user branch November 14, 2023 11:54
@jorhett
Copy link

jorhett commented Jan 9, 2024

It's been 5 months since this was reported, and 2 months since this was merged. Can we get this fix pushed out please?

@dhoppe
Copy link

dhoppe commented Feb 7, 2024 •
edited

@grcancelliere This issue still exists, because the new release is not available via pip.

❯ python3 -m pip list | grep molecule-plugins
────────────────────────────────────────────────────────────────────────────────
     STDIN
  23 mdurl                     0.1.2
  24 molecule                  6.0.3
  25 molecule-plugins          23.5.0
  26 mypy-extensions           1.0.0
  27 netaddr                   0.9.0
────────────────────────────────────────────────────────────────────────────────

https://pypi.org/project/molecule-plugins/

It looks like the GitHub action failed. This is related to #228

https://github.com/ansible-community/molecule-plugins/actions/runs/7529883395

hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request Feb 12, 2024
@hswong3i
Revert "podman: remove ansible_async_dir setting logic (ansible-commu…
19610e4 
…nity#182)"

This reverts commit 0244719.

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@hswong3i hswong3i mentioned this pull request Feb 12, 2024
Open
ppat pushed a commit to ppat/homelab-ops-ansible that referenced this pull request Mar 18, 2024
@renovate
chore(deps): update all python non-major dependencies (#4)
e1a62e4 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ansible-core](https://ansible.com/)
([source](https://togithub.com/ansible/ansible)) | `==2.15.9` ->
`==2.16.4` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/ansible-core/2.16.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ansible-core/2.16.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ansible-core/2.15.9/2.16.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ansible-core/2.15.9/2.16.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [ansible-lint](https://togithub.com/ansible/ansible-lint)
([changelog](https://togithub.com/ansible/ansible-lint/releases)) |
`==6.22.0` -> `==6.22.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/ansible-lint/6.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ansible-lint/6.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ansible-lint/6.22.0/6.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ansible-lint/6.22.0/6.22.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [commitizen](https://togithub.com/commitizen-tools/commitizen) |
`==3.12.0` -> `==3.18.4` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/commitizen/3.18.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/commitizen/3.18.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/commitizen/3.12.0/3.18.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/commitizen/3.12.0/3.18.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [molecule](https://togithub.com/ansible-community/molecule)
([changelog](https://togithub.com/ansible-community/molecule/releases))
| `==6.0.2` -> `==6.0.3` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/molecule/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/molecule/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/molecule/6.0.2/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/molecule/6.0.2/6.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[molecule-plugins](https://togithub.com/ansible-community/molecule-plugins)
([changelog](https://togithub.com/ansible-community/molecule-plugins/releases))
| `==23.5.0` -> `==23.5.3` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/molecule-plugins/23.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/molecule-plugins/23.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/molecule-plugins/23.5.0/23.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/molecule-plugins/23.5.0/23.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [pre-commit](https://togithub.com/pre-commit/pre-commit) | `==3.5.0`
-> `==3.6.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/pre-commit/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/pre-commit/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/pre-commit/3.5.0/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pre-commit/3.5.0/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [yamllint](https://togithub.com/adrienverge/yamllint) | `==1.33.0` ->
`==1.35.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/yamllint/1.35.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/yamllint/1.35.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/yamllint/1.33.0/1.35.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/yamllint/1.33.0/1.35.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ansible/ansible (ansible-core)</summary>

###
[`v2.16.4`](https://togithub.com/ansible/ansible/releases/tag/v2.16.4)

[Compare
Source](https://togithub.com/ansible/ansible/compare/v2.16.3...v2.16.4)

### Changelog

See the [full
changelog](https://togithub.com/ansible/ansible/blob/v2.16.4/changelogs/CHANGELOG-v2.16.rst)
for the changes included in this release.

### Release Artifacts

- Built Distribution:
[ansible_core-2.16.4-py3-none-any.whl](https://files.pythonhosted.org/packages/f8/bd/d7152b5b78e9363d30eb74b342c7dd577bf85ed28bcd8f4a8b02dce56553/ansible_core-2.16.4-py3-none-any.whl)
- [`2250452`](https://togithub.com/ansible/ansible/commit/2250452) bytes
- c55d9a5f55651eb6c7f004ca9a9ed854d8cc310e6b438d96cea051cf3d2b2710
(SHA256)
- Source Distribution:
[ansible-core-2.16.4.tar.gz](https://files.pythonhosted.org/packages/af/9c/12755b9ec6b696701fc7a33e8eab7a78f2b769dc0c966079c9005fffc7bf/ansible-core-2.16.4.tar.gz)
- [`3170397`](https://togithub.com/ansible/ansible/commit/3170397) bytes
- 2cd208b0915948c88bffad331e5d07097b6edca1872cb53375e51b6719e6a060
(SHA256)

###
[`v2.16.3`](https://togithub.com/ansible/ansible/releases/tag/v2.16.3)

[Compare
Source](https://togithub.com/ansible/ansible/compare/v2.16.2...v2.16.3)

### Changelog

See the [full
changelog](https://togithub.com/ansible/ansible/blob/v2.16.3/changelogs/CHANGELOG-v2.16.rst)
for the changes included in this release.

### Release Artifacts

- Built Distribution:
[ansible_core-2.16.3-py3-none-any.whl](https://files.pythonhosted.org/packages/b0/ec/6b5eed80eac9e3234fc9a9e61356ec2999b70cc23f83453f57e9a0fd3574/ansible_core-2.16.3-py3-none-any.whl)
- [`2250322`](https://togithub.com/ansible/ansible/commit/2250322) bytes
- 50c9f33a5b2ee645470a77f4bf99cf35d1ffdefef60388910020b0c58534bec1
(SHA256)
- Source Distribution:
[ansible-core-2.16.3.tar.gz](https://files.pythonhosted.org/packages/00/b9/7d2229459038cdfe84b6e4db76f97acae35cb46917a0d9a7e61d3e300637/ansible-core-2.16.3.tar.gz)
- [`3168893`](https://togithub.com/ansible/ansible/commit/3168893) bytes
- 76a8765a8586064ef073a299562e308fa2c180a75b5f7569bbd0f61d4171cdb3
(SHA256)

###
[`v2.16.2`](https://togithub.com/ansible/ansible/releases/tag/v2.16.2)

[Compare
Source](https://togithub.com/ansible/ansible/compare/v2.16.1...v2.16.2)

### Changelog

See the [full
changelog](https://togithub.com/ansible/ansible/blob/v2.16.2/changelogs/CHANGELOG-v2.16.rst)
for the changes included in this release.

### Release Artifacts

- Built Distribution:
[ansible_core-2.16.2-py3-none-any.whl](https://files.pythonhosted.org/packages/fe/0b/c28a50e7fbb7f6c6eb7bef4f023c5b408b0ff70934c2682be85e412b454d/ansible_core-2.16.2-py3-none-any.whl)
- [`2249791`](https://togithub.com/ansible/ansible/commit/2249791) bytes
- 494f002edcb17b02baef661ff27b8c9c750a534bdc0537ab29dc02e680817d92
(SHA256)
- Source Distribution:
[ansible-core-2.16.2.tar.gz](https://files.pythonhosted.org/packages/66/5f/3098fac361ca16fc42ac30a2da09939286afd9af289f156ac9fbe87595e9/ansible-core-2.16.2.tar.gz)
- [`3163899`](https://togithub.com/ansible/ansible/commit/3163899) bytes
- e4ab559e7e525b1c6f99084fca873bb014775d5ecbe845b7c07b8e9d6c9c048b
(SHA256)

###
[`v2.16.1`](https://togithub.com/ansible/ansible/releases/tag/v2.16.1)

[Compare
Source](https://togithub.com/ansible/ansible/compare/v2.16.0...v2.16.1)

### Changelog

See the [full
changelog](https://togithub.com/ansible/ansible/blob/v2.16.1/changelogs/CHANGELOG-v2.16.rst)
for the changes included in this release.

### Release Artifacts

- Built Distribution:
[ansible_core-2.16.1-py3-none-any.whl](https://files.pythonhosted.org/packages/f9/31/585576f619a974d9cdef009251d056a00e240c546f222d4bdb192d9e9208/ansible_core-2.16.1-py3-none-any.whl)
- [`2249752`](https://togithub.com/ansible/ansible/commit/2249752) bytes
- 8fc972ba6ba2161ecbde8166c0042080726c754f69ecb3ccd8c6636c98dc1c7e
(SHA256)
- Source Distribution:
[ansible-core-2.16.1.tar.gz](https://files.pythonhosted.org/packages/6f/3f/1dc35ba302137a4b00d17a42a47859c9e133ea2af56a285418e6c22be05d/ansible-core-2.16.1.tar.gz)
- [`3162449`](https://togithub.com/ansible/ansible/commit/3162449) bytes
- 4fd1b3c86237507c67113f6770d2470f87477cd88244938d100a2d0fc37bf986
(SHA256)

###
[`v2.16.0`](https://togithub.com/ansible/ansible/releases/tag/v2.16.0)

[Compare
Source](https://togithub.com/ansible/ansible/compare/v2.15.9...v2.16.0)

### Changelog

See the [full
changelog](https://togithub.com/ansible/ansible/blob/v2.16.0/changelogs/CHANGELOG-v2.16.rst)
for the changes included in this release.

### Release Artifacts

- Built Distribution:
[ansible_core-2.16.0-py3-none-any.whl](https://files.pythonhosted.org/packages/2f/ab/6357d8f3c17fec8c49c6119968292c14d3383c631bd900f6dc5593eb64a9/ansible_core-2.16.0-py3-none-any.whl)
- [`2247142`](https://togithub.com/ansible/ansible/commit/2247142) bytes
- 6b4870ac65b708953e1509b8ccca669731a17d2beadabd8208c9f90d189058ca
(SHA256)
- Source Distribution:
[ansible-core-2.16.0.tar.gz](https://files.pythonhosted.org/packages/6c/12/c0aec5705ee693986f62755fd3abbaf42ff3963980e42add4a2986ad79b0/ansible-core-2.16.0.tar.gz)
- [`3155083`](https://togithub.com/ansible/ansible/commit/3155083) bytes
- b4a6c60fbc2f51e3ae68ec733c931ef957a04d7c8c92aa39242990b0f8adf149
(SHA256)

</details>

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

###
[`v6.22.2`](https://togithub.com/ansible/ansible-lint/releases/tag/v6.22.2)

[Compare
Source](https://togithub.com/ansible/ansible-lint/compare/v6.22.1...v6.22.2)

#### Bugfixes

- Fix key error for name\[casing] rule
([#&#8203;3987](https://togithub.com/ansible/ansible-lint/issues/3987))
[@&#8203;ajinkyau](https://togithub.com/ajinkyau)
- Allow dashes in legacy role namespaces
([#&#8203;3962](https://togithub.com/ansible/ansible-lint/issues/3962))
[@&#8203;sur5r](https://togithub.com/sur5r)
- Use new ansible-compat verbosity levels
([#&#8203;3975](https://togithub.com/ansible/ansible-lint/issues/3975))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Remove dependency on newer requests library
([#&#8203;3959](https://togithub.com/ansible/ansible-lint/issues/3959))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Ignore set-property for systemd command
([#&#8203;3949](https://togithub.com/ansible/ansible-lint/issues/3949))
[@&#8203;alanbbr](https://togithub.com/alanbbr)
- Correct requires_ansible error message
([#&#8203;3954](https://togithub.com/ansible/ansible-lint/issues/3954))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Improve transformation for `no-free-form` rule
([#&#8203;3945](https://togithub.com/ansible/ansible-lint/issues/3945))
[@&#8203;ajinkyau](https://togithub.com/ajinkyau)
- Documentation improvement
([#&#8203;3946](https://togithub.com/ansible/ansible-lint/issues/3946))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- docs: fix grammatical issue in philosophy Q\&A section
([#&#8203;3934](https://togithub.com/ansible/ansible-lint/issues/3934))
[@&#8203;davidhulick](https://togithub.com/davidhulick)
- Update supported versions of ansible
([#&#8203;3930](https://togithub.com/ansible/ansible-lint/issues/3930))
[@&#8203;ajinkyau](https://togithub.com/ajinkyau)
- Fix backward compatibility
([#&#8203;3929](https://togithub.com/ansible/ansible-lint/issues/3929))
[@&#8203;McSim85](https://togithub.com/McSim85)
- Fix auto capitalization for name\[prefix] rule
([#&#8203;3922](https://togithub.com/ansible/ansible-lint/issues/3922))
[@&#8203;ajinkyau](https://togithub.com/ajinkyau)
- Fix role deps check for detecting path names
([#&#8203;3923](https://togithub.com/ansible/ansible-lint/issues/3923))
[@&#8203;cavcrosby](https://togithub.com/cavcrosby)
- Avoid warnings about PATH with pipx installations
([#&#8203;3920](https://togithub.com/ansible/ansible-lint/issues/3920))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)

###
[`v6.22.1`](https://togithub.com/ansible/ansible-lint/releases/tag/v6.22.1)

[Compare
Source](https://togithub.com/ansible/ansible-lint/compare/v6.22.0...v6.22.1)

#### Bugfixes

- Look for ansible binary in the same path as we are
([#&#8203;3903](https://togithub.com/ansible/ansible-lint/issues/3903))
[@&#8203;FliegenKLATSCH](https://togithub.com/FliegenKLATSCH)
- Avoid stacktrace with broken ansible.cfg files
([#&#8203;3916](https://togithub.com/ansible/ansible-lint/issues/3916))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Avoid jinja\[invalid] with ansible.builtin.mandatory filter
([#&#8203;3917](https://togithub.com/ansible/ansible-lint/issues/3917))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Remove support for deprecated include
([#&#8203;3722](https://togithub.com/ansible/ansible-lint/issues/3722))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Fix use of versioned github action
([#&#8203;3762](https://togithub.com/ansible/ansible-lint/issues/3762))
[@&#8203;karl-johan-grahn](https://togithub.com/karl-johan-grahn)
- Fix few URLs in README.md
([#&#8203;3915](https://togithub.com/ansible/ansible-lint/issues/3915))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Correct some usage examples for `package_latest`
([#&#8203;3914](https://togithub.com/ansible/ansible-lint/issues/3914))
[@&#8203;pablomh](https://togithub.com/pablomh)
- Add option to allow running with missing plugins and collection
dependencies
([#&#8203;3913](https://togithub.com/ansible/ansible-lint/issues/3913))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Avoid warnings from loading of deprecated modules
([#&#8203;3715](https://togithub.com/ansible/ansible-lint/issues/3715))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Log ignored exception details to debug log
([#&#8203;3900](https://togithub.com/ansible/ansible-lint/issues/3900))
[@&#8203;bluecmd](https://togithub.com/bluecmd)
- GitHub Action: properly respect the `working_directory` argument
([#&#8203;3905](https://togithub.com/ansible/ansible-lint/issues/3905))
[@&#8203;ptoscano](https://togithub.com/ptoscano)
- Allow to set `max_fail_percentage` as templated integer
([#&#8203;3901](https://togithub.com/ansible/ansible-lint/issues/3901))
[@&#8203;rebtoor](https://togithub.com/rebtoor)
- Fix setuptools-scm versioning
([#&#8203;3887](https://togithub.com/ansible/ansible-lint/issues/3887))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Add Fedora 39 to `meta.json`
([#&#8203;3893](https://togithub.com/ansible/ansible-lint/issues/3893))
[@&#8203;jsf9k](https://togithub.com/jsf9k)
- Use python 3.10 as primary version target
([#&#8203;3886](https://togithub.com/ansible/ansible-lint/issues/3886))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)

</details>

<details>
<summary>commitizen-tools/commitizen (commitizen)</summary>

###
[`v3.18.4`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3184-2024-03-14)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.18.3...v3.18.4)

##### Fix

-   **changelog**: include latest change when dry run and incremental

###
[`v3.18.3`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3183-2024-03-11)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.18.2...v3.18.3)

##### Fix

-   **warnings**: all warnings should go to `stdout`

###
[`v3.18.2`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3182-2024-03-11)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.18.1...v3.18.2)

##### Fix

- **git**: force the default git locale on methods relying on parsing
the output
([#&#8203;1012](https://togithub.com/commitizen-tools/commitizen/issues/1012))

###
[`v3.18.1`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3181-2024-03-11)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.18.0...v3.18.1)

##### Fix

-   **changelog**: changelog hook was not called on dry run

###
[`v3.18.0`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3180-2024-03-07)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.17.2...v3.18.0)

##### Feat

- **changelog**: `changelog_message_build_hook` can now generate
multiple changelog entries from a single commit
([#&#8203;1003](https://togithub.com/commitizen-tools/commitizen/issues/1003))

###
[`v3.17.2`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3172-2024-03-07)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.17.1...v3.17.2)

##### Fix

- **changelog**: ensure `changelog_message_builder_hook` can access and
modify `change_type`
([#&#8203;1002](https://togithub.com/commitizen-tools/commitizen/issues/1002))

###
[`v3.17.1`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3171-2024-03-07)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.17.0...v3.17.1)

##### Fix

- **bump**: pre and post bump hooks were failing when an increment was
provided (fix
[#&#8203;1004](https://togithub.com/commitizen-tools/commitizen/issues/1004))

###
[`v3.17.0`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3170-2024-03-06)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.16.0...v3.17.0)

##### Feat

- **changelog**: `changelog_message_build_hook` can remove message by
returning a falsy value

###
[`v3.16.0`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3160-2024-02-26)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.15.0...v3.16.0)

##### Feat

-   **commands**: add bump --exact

##### Fix

-   **bump**: change --exact-increment to --increment-mode
- **bump**: only get and validate commits if increment is not provided
-   Improve type annotations

###
[`v3.15.0`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3150-2024-02-17)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.14.1...v3.15.0)

##### Feat

-   **bump**: functionality to add build-metadata to version string

###
[`v3.14.1`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3141-2024-02-04)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.14.0...v3.14.1)

##### Fix

-   **bump**: remove unused method
-   **scm**: only search tags that are reachable by the current commit

###
[`v3.14.0`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3140-2024-02-01)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.13.0...v3.14.0)

##### Feat

- properly bump versions between prereleases
([#&#8203;799](https://togithub.com/commitizen-tools/commitizen/issues/799))

###
[`v3.13.0`](https://togithub.com/commitizen-tools/commitizen/blob/HEAD/CHANGELOG.md#v3130-2023-12-03)

[Compare
Source](https://togithub.com/commitizen-tools/commitizen/compare/v3.12.0...v3.13.0)

##### Feat

- **commands-bump**: automatically create annotated tag if message is
given
-   add tag message argument to cli
-   **git**: add get tag message function
-   add custom message to annotated git tag

##### Fix

-   **test-bump-command**: typo in --annotated-tag option inside test
-   **commitizen-git**: add quotes for tag message

##### Refactor

-   **commands-bump**: make changelog variable in 1 line
-   **commands-bump**: cast str to bool

</details>

<details>
<summary>ansible-community/molecule (molecule)</summary>

###
[`v6.0.3`](https://togithub.com/ansible/molecule/releases/tag/v6.0.3)

[Compare
Source](https://togithub.com/ansible-community/molecule/compare/v6.0.2...v6.0.3)

#### Bugfixes

- Change molecule_inventory in podman example to remove ansible warning
([#&#8203;4086](https://togithub.com/ansible-community/molecule/issues/4086))
[@&#8203;buckaroogeek](https://togithub.com/buckaroogeek)
- Update collection structure image in the docs
([#&#8203;4098](https://togithub.com/ansible-community/molecule/issues/4098))
[@&#8203;ajinkyau](https://togithub.com/ajinkyau)
- Enable ansible-lint
([#&#8203;4069](https://togithub.com/ansible-community/molecule/issues/4069))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Correct git-archival settings
([#&#8203;4071](https://togithub.com/ansible-community/molecule/issues/4071))
[@&#8203;ssbarnea](https://togithub.com/ssbarnea)
- Docs: highlight importance of `ansible_collections` at root dir
([#&#8203;4060](https://togithub.com/ansible-community/molecule/issues/4060))
[@&#8203;felher](https://togithub.com/felher)
- Skip create step when created == true
([#&#8203;4038](https://togithub.com/ansible-community/molecule/issues/4038))
[@&#8203;mluzarreta](https://togithub.com/mluzarreta)
- Address ansible-lint reported issues
([#&#8203;4056](https://togithub.com/ansible-community/molecule/issues/4056))
[@&#8203;muellerbe](https://togithub.com/muellerbe)
- Add podman driver option to podman config
([#&#8203;4062](https://togithub.com/ansible-community/molecule/issues/4062))
[@&#8203;brandor5](https://togithub.com/brandor5)
- Fix docker and podman examples to work with multiple platforms
([#&#8203;4068](https://togithub.com/ansible-community/molecule/issues/4068))
[@&#8203;clickthisnick](https://togithub.com/clickthisnick)
- Update docs to remove references to Docker being the default driver
([#&#8203;4065](https://togithub.com/ansible-community/molecule/issues/4065))
[@&#8203;Qalthos](https://togithub.com/Qalthos)
- Fix forbidden implicit octal value
([#&#8203;4049](https://togithub.com/ansible-community/molecule/issues/4049))
[@&#8203;jooola](https://togithub.com/jooola)
- Pin linkchecker version
([#&#8203;4050](https://togithub.com/ansible-community/molecule/issues/4050))
[@&#8203;zhan9san](https://togithub.com/zhan9san)
- Update getting-started.md
([#&#8203;4030](https://togithub.com/ansible-community/molecule/issues/4030))
[@&#8203;aogier](https://togithub.com/aogier)
- Address documentation username typo
([#&#8203;4031](https://togithub.com/ansible-community/molecule/issues/4031))
[@&#8203;iamgini](https://togithub.com/iamgini)

</details>

<details>
<summary>ansible-community/molecule-plugins (molecule-plugins)</summary>

###
[`v23.5.3`](https://togithub.com/ansible-community/molecule-plugins/releases/tag/v23.5.3)

[Compare
Source](https://togithub.com/ansible-community/molecule-plugins/compare/v23.5.0...v23.5.3)

#### Bugfixes

- update docker collection
([#&#8203;217](https://togithub.com/ansible-community/molecule-plugins/issues/217))
[@&#8203;zhan9san](https://togithub.com/zhan9san)
- Use v6-alpha1 molecule version for tests by
[@&#8203;audgirka](https://togithub.com/audgirka) in
[ansible-community/molecule-plugins#180
- Prevent empty destroy from deleting other EC2 instances by
[@&#8203;Thomas-McKanna](https://togithub.com/Thomas-McKanna) in
[ansible-community/molecule-plugins#170
- fix duplicate test names by
[@&#8203;alicekaerast](https://togithub.com/alicekaerast) in
[ansible-community/molecule-plugins#197
- pass vpc_subnet_id explicitly to avoid amazon.aws error by
[@&#8203;danielpodwysocki](https://togithub.com/danielpodwysocki) in
[ansible-community/molecule-plugins#199
- Fixes destroy playbook failure if vpc lookup is required by
[@&#8203;tkimball83](https://togithub.com/tkimball83) in
[ansible-community/molecule-plugins#184
- podman: remove ansible_async_dir setting logic by
[@&#8203;grcancelliere](https://togithub.com/grcancelliere) in
[ansible-community/molecule-plugins#182
- Add Python 3.12 to test matrix by
[@&#8203;cristianonicolai](https://togithub.com/cristianonicolai) in
[ansible-community/molecule-plugins#207
- Remove dependency to molecule.test by
[@&#8203;cristianonicolai](https://togithub.com/cristianonicolai) in
[ansible-community/molecule-plugins#206
- Disable registry login when registry.url is empty by
[@&#8203;dometto](https://togithub.com/dometto) in
[ansible-community/molecule-plugins#214
- Support the shm_size docker configuration option by
[@&#8203;zleinweber](https://togithub.com/zleinweber) in
[ansible-community/molecule-plugins#216
- Fixes podman always remove existing containers by
[@&#8203;juanvalino](https://togithub.com/juanvalino) in
[ansible-community/molecule-plugins#187
- Handle Docker errors correctly by
[@&#8203;alicekaerast](https://togithub.com/alicekaerast) in
[ansible-community/molecule-plugins#196
- Plugin openstack (2) by
[@&#8203;juanlufont](https://togithub.com/juanlufont) in
[ansible-community/molecule-plugins#219

#### New Contributors

- [@&#8203;alicekaerast](https://togithub.com/alicekaerast) made their
first contribution in
[ansible-community/molecule-plugins#197
- [@&#8203;pbjhelmert](https://togithub.com/pbjhelmert) made their first
contribution in
[ansible-community/molecule-plugins#195
- [@&#8203;tkimball83](https://togithub.com/tkimball83) made their first
contribution in
[ansible-community/molecule-plugins#184
- [@&#8203;cristianonicolai](https://togithub.com/cristianonicolai) made
their first contribution in
[ansible-community/molecule-plugins#205
- [@&#8203;dometto](https://togithub.com/dometto) made their first
contribution in
[ansible-community/molecule-plugins#214
- [@&#8203;zleinweber](https://togithub.com/zleinweber) made their first
contribution in
[ansible-community/molecule-plugins#216
- [@&#8203;juanvalino](https://togithub.com/juanvalino) made their first
contribution in
[ansible-community/molecule-plugins#187
- [@&#8203;juanlufont](https://togithub.com/juanlufont) made their first
contribution in
[ansible-community/molecule-plugins#219

</details>

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

###
[`v3.6.2`](https://togithub.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#362---2024-02-18)

[Compare
Source](https://togithub.com/pre-commit/pre-commit/compare/v3.6.1...v3.6.2)

\==================

##### Fixes

-   Fix building golang hooks during `git commit --all`.
- [#&#8203;3130](https://togithub.com/pre-commit/pre-commit/issues/3130)
PR by [@&#8203;asottile](https://togithub.com/asottile).
- [#&#8203;2722](https://togithub.com/pre-commit/pre-commit/issues/2722)
issue by [@&#8203;pestanko](https://togithub.com/pestanko) and
[@&#8203;matthewhughes934](https://togithub.com/matthewhughes934).

###
[`v3.6.1`](https://togithub.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#361---2024-02-10)

[Compare
Source](https://togithub.com/pre-commit/pre-commit/compare/v3.6.0...v3.6.1)

\==================

##### Fixes

-   Remove `PYTHONEXECUTABLE` from environment when running.
- [#&#8203;3110](https://togithub.com/pre-commit/pre-commit/issues/3110)
PR by [@&#8203;untitaker](https://togithub.com/untitaker).
-   Handle staged-files-only with only a crlf diff.
- [#&#8203;3126](https://togithub.com/pre-commit/pre-commit/issues/3126)
PR by [@&#8203;asottile](https://togithub.com/asottile).
    -   issue by [@&#8203;tyyrok](https://togithub.com/tyyrok).

###
[`v3.6.0`](https://togithub.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#360---2023-12-09)

[Compare
Source](https://togithub.com/pre-commit/pre-commit/compare/v3.5.0...v3.6.0)

\==================

##### Features

-   Check `minimum_pre_commit_version` first when parsing configs.
- [#&#8203;3092](https://togithub.com/pre-commit/pre-commit/issues/3092)
PR by [@&#8203;asottile](https://togithub.com/asottile).

##### Fixes

-   Fix deprecation warnings for `importlib.resources`.
- [#&#8203;3043](https://togithub.com/pre-commit/pre-commit/issues/3043)
PR by [@&#8203;asottile](https://togithub.com/asottile).
-   Fix deprecation warnings for rmtree.
- [#&#8203;3079](https://togithub.com/pre-commit/pre-commit/issues/3079)
PR by [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon).

##### Updating

-   Drop support for python<3.9.
- [#&#8203;3042](https://togithub.com/pre-commit/pre-commit/issues/3042)
PR by [@&#8203;asottile](https://togithub.com/asottile).
- [#&#8203;3093](https://togithub.com/pre-commit/pre-commit/issues/3093)
PR by [@&#8203;asottile](https://togithub.com/asottile).

</details>

<details>
<summary>adrienverge/yamllint (yamllint)</summary>

###
[`v1.35.1`](https://togithub.com/adrienverge/yamllint/blob/HEAD/CHANGELOG.rst#1351-2024-02-16)

[Compare
Source](https://togithub.com/adrienverge/yamllint/compare/v1.35.0...v1.35.1)

-   Restore ignoration of files passed as command-line arguments
-   Revert API change from version 1.35.0

###
[`v1.35.0`](https://togithub.com/adrienverge/yamllint/blob/HEAD/CHANGELOG.rst#1350-2024-02-15)

[Compare
Source](https://togithub.com/adrienverge/yamllint/compare/v1.34.0...v1.35.0)

-   Fix failure on broken symlinks that should be ignored
- API change: `linter.run(stream, config)` doesn't filter files anymore
-   Docs: Restore official Read the Docs theme

###
[`v1.34.0`](https://togithub.com/adrienverge/yamllint/blob/HEAD/CHANGELOG.rst#1340-2024-02-06)

[Compare
Source](https://togithub.com/adrienverge/yamllint/compare/v1.33.0...v1.34.0)

-   Config: validate `ignore-from-file` inside rules
- Rule `quoted-strings`: fix `only-when-needed` in flow maps and
sequences
-   Rule `key-duplicates`: add `forbid-duplicated-merge-keys` option
-   Rule `quoted-strings`: add `check-keys` option
-   Docs: add GitLab CI example
-   Rule `truthy`: adapt forbidden values based on YAML version

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ppat/homelab-ops-ansible).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rkz f0rkz Awaiting requested review from f0rkz

@zhan9san zhan9san Awaiting requested review from zhan9san

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman containers break on Get passwd entries for USER env
5 participants
@grcancelliere @zhan9san @jorhett @dhoppe @f0rkz