Update direct Molecule dependencies: ansible-lint>=4.0.1,<5

[themr0c]

Closes #1607

Signed-off-by: Fabrice Flore-Thebault themr0c@users.noreply.github.com

PR Type

• Bugfix Pull Request

[themr0c]

hi, i believe travis errors are not related to this commit

[webknjaz]

@themr0c @gundalow I've restarted failing jobs (which indeed look unrelated), other than that it's good to merge.

[gundalow]

Thanks everyone, merged.

[Rickkwa]

Hi all, I came across this and I have a concern I'm hoping you can take a look at regarding upgrading the ansible-lint version. Let me preface this by saying that I am new to the project and I haven't been following along with the development changes, nor have I seen/ran the test cases that Molecule has. There may be another PR that has addressed my issue, I do not know.

I have Molecule 2.19.0 installed (ie. I'm not running the latest dev version), and simply upgrading the version of ansible-lint to 4.0.1 causes the linter to not catch errors anymore.

Here is how I've reproduced it:

# Running on Centos 7, with Python 2.7.5

virtualenv ansible-2.7.5
source ansible-2.7.5/bin/activate

mkdir -p testrole/tasks
cd testrole

cat <<EOF > tasks/main.yml
---

- file:
    path: /tmp/deleteme
    state: touch
EOF

pip install ansible==2.7.5 molecule==2.19.0

ansible-lint --version
# I get 3.4.23 as expected from the pinned version

molecule init scenario -r testrole
molecule lint

# Expect to see lint error "All tasks should be named"

pip install --upgrade ansible-lint
ansible-lint --version
# I get 4.0.1

molecule lint
# See no linting errors, which is unexpected

ansible-lint .
# But running the linter directly still gives me "All tasks should be named"

[Rickkwa]

I've tried with the current latest commit in master (abc4df6) instead of 2.19.0 and yeah, molecule lint doesn't catch the linting error, but ansible-lint . does.

[decentral1se]

@Rickkwa, thanks for doing some digging. There was some discussion on the IRC around ansible-lint being invoked by Molecule incorrectly. There was a documentation PR submitted for configuring ansible-lint when the default Molecule options does not work (for some reason): #1722. So, I'm starting to get suspicious ;) I'm going to create a new issue.

EDIT: Created #1723.