Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

molecule lint does not match what ansible-lint . does #1723

Closed
decentral1se opened this issue Feb 4, 2019 · 8 comments
Closed

molecule lint does not match what ansible-lint . does #1723

decentral1se opened this issue Feb 4, 2019 · 8 comments
Labels
blocked Blocked in some way upstream or not. bug

Comments

@decentral1se
Copy link
Contributor

Issue Type

  • Bug report

Molecule and Ansible details

HEAD and latest release AFAIK.

Molecule installation method (one of):

  • pip

Ansible installation method (one of):

  • pip

Desired Behavior

molecule lint and ansible-lint . behave identically.

Actual Behaviour

See #1675 (comment) and #1675 (comment).
@decentral1se decentral1se mentioned this issue Feb 4, 2019
Merged
@decentral1se
Copy link
Contributor Author

decentral1se commented Feb 4, 2019 •
edited
Loading

Potentially related was #1722. Basically, the configuration options were not working correctly from the molecule.yml (not sure on details) and an .ansible-lint had to be introduced to configure ansible-lint correctly.

@Rickkwa
Copy link

Rickkwa commented Feb 4, 2019

Potential blocker for 2.20 release, as having linting break would be a pretty big deal I think.

@decentral1se decentral1se added this to the v2.20 milestone Feb 5, 2019
@decentral1se
Copy link
Contributor Author

Agreed.

@pilou- pilou- mentioned this issue Feb 6, 2019
Merged
pilou- added a commit to pilou-/ansible-lint that referenced this issue Feb 6, 2019
@pilou-
Check DEFAULT_ROLES_PATH before basedir
c80ad2d 
Fix behavior when ANSIBLE_ROLES_PATH is defined, for example:

    cd test/roles/test-role
    ANSIBLE_ROLES_PATH=.. ansible-lint molecule/default/include-import-role.yml

Fix ansible/molecule#1723

Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
@decentral1se
Copy link
Contributor Author

Thanks for that fix @pilou-!

awcrosby pushed a commit to ansible/ansible-lint that referenced this issue Feb 7, 2019
@pilou- @awcrosby
Check ANSIBLE_ROLES_PATH before basedir (#478)
10325b4 
* Test: use testproject/roles instead of roles/roles

'roles' doesn't seem an adequate toplevel name when testing three
directories depth.

Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>

* Test: use ansible-lint the way molecule does

Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>

* Check DEFAULT_ROLES_PATH before basedir

Fix behavior when ANSIBLE_ROLES_PATH is defined, for example:

    cd test/roles/test-role
    ANSIBLE_ROLES_PATH=.. ansible-lint molecule/default/include-import-role.yml

Fix ansible/molecule#1723

Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
@decentral1se
Copy link
Contributor Author

OK, the fix is merged, awaiting a release which is being tracked at https://github.com/ansible/ansible-lint/milestone/15.

@decentral1se decentral1se added the blocked Blocked in some way upstream or not. label Feb 8, 2019
@Rickkwa
Copy link

Rickkwa commented Feb 12, 2019

Looks like ansible-lint 4.1.0 was released. I ran the commands from my original comment and looks good.

@gundalow
Copy link
Contributor

@Rickkwa Thank you for confirming.

@pilou-
Copy link
Contributor

pilou- commented Feb 13, 2019

@gundalow should not we exclude ansible-lint 4.0.0 and 4.0.1 (from allowed dependencies) ?

decentral1se added a commit to decentral1se/molecule that referenced this issue Feb 13, 2019
@decentral1se
Exclude ansible-lint 4.0.1
dab6259 
Because of ansible#1723.

Signed-off-by: Luke Murphy <lukewm@riseup.net>
@decentral1se decentral1se mentioned this issue Feb 13, 2019
Merged
gundalow pushed a commit that referenced this issue Feb 13, 2019
@lwm @gundalow
Exclude ansible-lint 4.0.1 (#1743)
4a1f264 
Because of #1723.

Signed-off-by: Luke Murphy <lukewm@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked in some way upstream or not. bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gundalow @pilou- @decentral1se @Rickkwa