Add check for offline installs and allow to specify custom xml config #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
added
the
minor_changes
guidograzioli
changed the title
rpelisse
approved these changes
Apr 25, 2023
| owner: "{{ wildfly_install.user }}" | ||
| mode: 0640 | ||
| become: yes | ||
| when: wildfly_install.config_custom | length > 0 |
There was a problem hiding this comment.
I would add wildfly_install is defined and wildfly_install.config_custom is defined, but I'm on the paranoid side of validation :)
rpelisse
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new variable
wildfly_config_custom_filewhich allows to pass a custom file/templated standalone.xml configuration to use as a base config. Defaults to empty string (do not use the feature).wildfly_config_basestandalone.xmlunlesswildfly_config_custom_fileis usedwildfly_config_custom_file''wildfly_config_basechanges it default tostandalone.xmlonly whenwildfly_config_custom_fileis not used, otherwise it uses whatever filename is passed in.Also, improves fix for #101 with a pre-req conditional which fails the play at a very early stage when offline_install is enabled, but the necessary zipfiles are not available on the controller.