Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Installation of User Python Dependencies at Container Runtime #1250

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

dmbonsall
Copy link
Contributor

@dmbonsall dmbonsall commented May 27, 2023

Resolves #1245

Documentation: semaphoreui/semaphore-docs#17

@dmbonsall
Copy link
Contributor Author

Hello @fiftin, would you mind reviewing this PR?

@mjkl-gh
Copy link

mjkl-gh commented Jul 10, 2023

Would be interested in this as well

@caiodelgadonew
Copy link

Hello @fiftin , any plans for releasing this??

@snvad
Copy link

snvad commented Nov 10, 2023

I join those who are waiting this feature

@hackathi
Copy link

hackathi commented Mar 6, 2024

I also need this feature. Is this blocked by something?

@tboerger
Copy link
Collaborator

tboerger commented Mar 8, 2024

It should add options for Python AND Ansible collections installation.

@dmbonsall
Copy link
Contributor Author

I also need this feature. Is this blocked by something?

@hackathi, this this has sat a while because @fiftin has not responded to the PR, and they are the only person with write access as far as I know. If we can get bandwidth from them, or someone else with write access to provide feedback, then this can move forward.

@dmbonsall
Copy link
Contributor Author

It should add options for Python AND Ansible collections installation.

@tboerger, given that Semaphore already supports this through a file placed in the project directory at collections/requirements.yml, wouldn't adding a collections install step be redundant to that mechanism? Having two install steps for that would also mean that the runner would have to take care to resolve the dependencies installed at startup plus the dependencies installed for the task.

@hackathi
Copy link

I also need this feature. Is this blocked by something?

@hackathi, this this has sat a while because @fiftin has not responded to the PR, and they are the only person with write access as far as I know. If we can get bandwidth from them, or someone else with write access to provide feedback, then this can move forward.

Thank you for your insight! Well then let's wait together; if there were some technical blockers I'd have looked into contributing towards those.

@lima-faux
Copy link
Contributor

also waiting on this 🙏

@m0canu1
Copy link

m0canu1 commented Apr 10, 2024

me also waiting for this

@fiftin fiftin merged commit f73d711 into semaphoreui:develop Apr 15, 2024
4 checks passed
fiftin added a commit to semaphoreui/semaphore-docs that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Installation of User Python Dependencies at Container Runtime
9 participants