Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function “Extra CLI Arguments” in "Create Task UI”. #563

Merged
merged 4 commits into from
Oct 22, 2018

Conversation

dahyungKwon
Copy link

Hello I'm newbie :)

I needed to additional arguments field in task launch process that is after clicking on Run button. It is very useful for us to be able to add extra arguments just before execution.

So I add “Extra CLI Arguments” filed to “Create Task” UI.

semaphore_args

And I added the following tasks to make the process work.

  • Added "Extra CLI Arguments" filed to "Create Task" UI.
  • Added arguments column on "task" table for adding arguments inserted by "Create Task" UI.
  • Added "task.arguments" value to getPlaybookArgs () method for append the value to command's arguments.

@strangeman
Copy link
Contributor

Some tests are failed, can you fix it? https://circleci.com/gh/ansible-semaphore/semaphore/700

@dahyungKwon
Copy link
Author

Some tests are failed, can you fix it? https://circleci.com/gh/ansible-semaphore/semaphore/700

I have specified the version for migration to run the v2.5.2.sql file.

@strangeman strangeman merged commit 2b13fe6 into semaphoreui:develop Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants