Fix mulekick dependency removal #585
Conversation
It doesn't otherwise build on windows since by default it's `1`: ```powershell Taskfiles versions should match. First is "2" but second is "1" ``` backup
Revert one more commit
|
There is some issue with CI setup, specifically with go-task, but I don't know how to resolve that. Anyway I have built and tested it also manually by just clicking around in the UI, nothing appears to be broken, at least based on what I have seen. And at any rate it builds fine, which is better than current state of upstream. Maybe @matejkramny can take a look and merge this? |
|
@strangeman any comments? Looks good to me. One thing i'm noticing (unrelated to the PR), the |
I guess the guy has left somewhere. Can you merge this? As much potential as I see with this project, it doesn't give a strong impression with stagnation like this. Besides - he merged the PR that removed mulekick initially, which broke the upstream completely, it can't get worse if you merge a fix to that. Frankly to get more activity on the project, requirements to merge stuff need to be loosen and speed of merging and closing issues increased. Not enough people are active on, or using this software for that to be a risk at this stage anyway. A bigger risk is the seeming stagnation of the community, since despite all the potential this project has as an alternative to the (very faulty) AWX/Tower, it won't be a serious contender to it, if it doesn't get more popular and gain a more active community. |
|
fair point @megakoresh. I'll take that into consideration. |
Removal of mulekick dependency has broken the whole project. (that time I said it "builds" fine for me? Yeah, it didn't, I confused "compile" with "build"). This should fix it by changing the code to use gorilla/mux router directly. Mulekick has been effectively removed.
Two functions that remained have been moved to util package.
router.gocontains most of the changes. Looks a bit uglier in places, but hopefully more robust and transparent now.With my node.js background I tried to make mux behave like Koa first, which is not a bright idea of course. Still - could be useful, so I kept it in history.