Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to setuptools_scm #494

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Conversation

nitzmahone
Copy link
Member

  • remove pbr usage entirely
  • switch to PyPA-recommended package layout (Python packages under root src/ dir)
  • remove legacy setup.py in favor of PEP517 pyproject.toml
  • still using setup.cfg for most metadata until setuptools support for it in pyproject.toml stabilizes further
  • pin min/max PEP518 build deps for setuptools and setuptools_scm to avoid future packaging metadata deprecation/removal issues
  • configure export-subst ref/metadata smuggling in archives for setuptools_scm when not installing from a git checkout or sdist (eg downstream packagers installing directly from GH ref tarballs)

@nitzmahone nitzmahone requested a review from a team as a code owner April 25, 2023 23:55
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Apr 25, 2023
@sivel
Copy link
Member

sivel commented Apr 26, 2023

There is some pbr stuff left in docs/ that needs to be removed, it isn't used or required at all based on my research for runner. Although part of it is modifying docs/requirements.in which is used to generate (manually, no in repo tooling) the docs/requirements.txt file. And looks like with runner sphinx-ansible-theme is missing from requirements.in.

It's possible the docs/requirements.txt can just be edited, without regenerating.

setup.cfg Outdated Show resolved Hide resolved
@github-actions github-actions bot added the docs Changes to documentation label Apr 26, 2023
@nitzmahone nitzmahone merged commit 3cdbe16 into ansible:devel Apr 26, 2023
@Shrews Shrews linked an issue Apr 27, 2023 that may be closed by this pull request
@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Changes to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix package versioning when installed from git clone
4 participants