Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing underscore in target_scripts path #524

Merged
merged 1 commit into from
May 5, 2023

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 5, 2023

  • Without this project data files are not copied in the installation which are required.

* Without this project data files are not copied in the
  installation which are required.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested a review from a team as a code owner May 5, 2023 17:06
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label May 5, 2023
@nitzmahone nitzmahone removed the needs_triage New item that needs to be triaged label May 5, 2023
@nitzmahone
Copy link
Member

While testing this fix, it appears that this option is just ignored under almost all circumstances- the only way I could actually get it to break in a way where this option was actually consulted was when directly pip install ing a git clone with the .git dir removed. python -m build, and pip install with a GH ref archive or a functional git worktree all basically seem to ignore this option and package everything.

I don't see any harm to having it actually describe the right thing, but we may end up needing to go back to MANIFEST.in at some point anyway. 🤷‍♂️

Thanks!

@nitzmahone nitzmahone merged commit 9a221ca into ansible:devel May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants