Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow git dependencies in galaxy.yml files #321

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Allow git dependencies in galaxy.yml files #321

merged 1 commit into from
Aug 23, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea requested a review from a team as a code owner August 22, 2023 17:00
@github-actions github-actions bot added the bug Something isn't working label Aug 22, 2023
@ssbarnea ssbarnea force-pushed the fix/git-deps branch 2 times, most recently from 5d04159 to 57e58ec Compare August 22, 2023 17:04
@ssbarnea ssbarnea marked this pull request as draft August 22, 2023 17:05
@ssbarnea ssbarnea marked this pull request as ready for review August 22, 2023 17:13
cidrblock
cidrblock approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from here

@ssbarnea ssbarnea requested a review from sivel August 22, 2023 17:57
@ssbarnea ssbarnea merged commit aaed221 into main Aug 23, 2023
22 checks passed
@ssbarnea ssbarnea deleted the fix/git-deps branch August 23, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgirka audgirka audgirka approved these changes

@cidrblock cidrblock cidrblock approved these changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

offline mode still validates git versions
4 participants
@ssbarnea @sivel @audgirka @cidrblock