Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport noxfile and other workflow changes #317

Closed
gotmax23 opened this issue Aug 21, 2023 · 5 comments
Closed

Backport noxfile and other workflow changes #317

gotmax23 opened this issue Aug 21, 2023 · 5 comments
Assignees
Labels
doc builds Relates to building the documentation

Comments

@gotmax23
Copy link
Collaborator

We should backport #314 and #258 that add the initial workflow automation after letting them sit on devel for a bit. We can also backport the requirements-relaxed change (#271). We should decide whether to create scheduled dependency updates for the stable branches or leave it to be done manually. I assume the manual approach is preferred.

@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Aug 21, 2023
@samccann
Copy link
Contributor

Is this suggestion to backport only to stable-2.15 or all the way to stable-2.13?

@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2023
@samccann
Copy link
Contributor

As for scheduled dependency updates on stable branches - for non-latest I would definitely say no, we don't do it at all unless something has broken. Those are supposed to be 'bugfix/securityfix' releases so we should follow that approach even in docs imo.

For latest - my preference is 'if it ain't broke, don't fix it'. As in again, dependency updates on all stable branches should be limited to only what is required, not just what is desired. So unless we had a strong need, we woudln't update sphinx in a stable branch. We'd avoid updating antsibull-docs as well unless it was an agreed feature we wanted to add to the latest docs. Bugfixes for antsibull-docs would definitely get backported tho if that makes sense?

@samccann samccann added the doc builds Relates to building the documentation label Aug 24, 2023
@gotmax23
Copy link
Collaborator Author

gotmax23 commented Sep 5, 2023

The stable-2.15 backport (#342) was merged earlier today. Thanks for reviewing, @oraNod. I'll open equivalent stable-2.14 and stable-2.13 PRs later.

@gotmax23
Copy link
Collaborator Author

stable-2.14: #685

@gotmax23 gotmax23 self-assigned this Oct 22, 2023
gotmax23 added a commit that referenced this issue Oct 25, 2023
@gotmax23
Copy link
Collaborator Author

Fixed in #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc builds Relates to building the documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants