Cypress: add view-only tests #1082

himdel · 2021-10-12T02:20:32Z

A cy.settings Cypress command was added in #1116.
(It also added cypress.env.json.template but didn't document it, fixing here.)

Adding a test for view-only mode, using cy.settings to change the server settings for the duration.

With GALAXY_ENABLE_UNAUTHENTICATED_COLLECTION_ACCESS & GALAXY_ENABLE_UNAUTHENTICATED_COLLECTION_DOWNLOAD, test that Collections, Namespaces and Documentation are in the menu, we can see the list & detail screens, and no Add/Upload/Create buttons, as well as Unauthorized elsewhere.

With just GALAXY_ENABLE_UNAUTHENTICATED_COLLECTION_ACCESS: check that collection detail screen has the alert instead of a download button.

And changing the settings for github actions to GALAXY_REQUIRE_CONTENT_APPROVAL=False, so that galaxykit collection upload doesn't require approvals everywhere (AAH-628 will deal with enabling it back for approval tests). This should unblock #1117 & #1137.

❕ Note: when testing locally, most likely you first need to:

update galaxykit to 0.5.2+: python -m pip install --user galaxykit --upgrade
add settings and restart to your test/cypress.env.json (see test/cypress.env.json.template and test/README.md)

himdel · 2021-10-14T02:02:01Z

galaxykit collection upload...

local dev setup:

sendto(3, "POST /api/automation-hub//content/inbound-admin/v3/artifacts/collections/"..., 402, 0, NULL, 0) = 402
sendto(3, "----------------------------8a77377278a14d509f9514624920abae\r\nContent-Disposition: form-data; name=\"sha256\"\r\nf3a9d43b270911bff8830d2f0b8d53c68fd041cedf81ff3709e1cadd3ce81ef1\r\n-------------------------"..., 2023, 0, NULL, 0) = 2023
recvfrom(3, "HTTP/1.1 202 Accepted\r\nX-Powered-By: Express\r\nserver: gunicorn\r\ndate: Thu, 14 Oct 2021 01:45:57 GMT\r\nconnection: close\r\ncontent-type: application/json\r\nvary: Accept, Accept-Language, Cookie\r\nallow: PO"..., 8192, 0, NULL, NULL) = 460

with pulp-oci-images:

sendto(3, "POST /api/galaxy//content/inbound-admin/v3/artifacts/collections/"..., 394, 0, NULL, 0) = 394
sendto(3, "----------------------------10529abe4e3740668301c8f531c3beeb\r\nContent-Disposition: form-data; name=\"sha256\"\r\n6fe2db72c654b8150d5d031650dea161fd4b607c5cddb04b4ce5b769f4cbfa7d\r\n-------------------------"..., 2021, 0, NULL, 0) = 2021
recvfrom(3, "HTTP/1.1 404 Not Found\r\nServer: nginx/1.14.1\r\nDate: Thu, 14 Oct 2021 01:44:46 GMT\r\nContent-Type: text/html\r\nContent-Length: 179\r\nConnection: keep-alive\r\nVary: Accept-Language\r\nContent-Language: en-us\r"..., 8192, 0, NULL, NULL) = 468

I think this may be a gunicorn vs nginx difference in handling the double //, the URL the UI uses is the same, except with just one slash.

=> ansible/galaxykit#14 .. released in galaxykit 0.5.2
(.. and 29db1a4 here to disable approvals)

Related to ansible/ansible-hub-ui#1082 (comment) {galaxy_root}/content yields a string with a double slash when used with a --server value with a trailing slash (the default) double slashes don't seem to work with pulp-oci-images (or nginx?), using urljoin as elsewhere

both describes need it

…nd `restart`

and wait for namespace detail title

…UIRE_CONTENT_APPROVAL) GALAXY_REQUIRE_CONTENT_APPROVAL=True is the default, and causes collections added by `galaxykit collection upload` to only appear in Approvals UI, where they need to be approved first before appearing (AAH-628 is open for approval tests)

…nsible#1142

ZitaNemeckova

LGTM 👍

patchback · 2021-11-01T14:44:23Z

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/fb0a8d09bf9793ab95b9f32762f2e24493c53a3c/pr-1082

Backported as #1186

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* view-only: simple test for view-only mode * view-only: add tests * view-only: galaxykit collection upload, to ensure there's a collection both describes need it * test/README: mention cypress.env.json.template, document `settings` and `restart` * view-only: actually go to namespace detail and wait for namespace detail title * github cypress settings.py: turn off collections approval (GALAXY_REQUIRE_CONTENT_APPROVAL) GALAXY_REQUIRE_CONTENT_APPROVAL=True is the default, and causes collections added by `galaxykit collection upload` to only appear in Approvals UI, where they need to be approved first before appearing (AAH-628 is open for approval tests) * test/README: also document `containers` in `cypress.env.json`, from #1142 (cherry picked from commit fb0a8d0)

* view-only: simple test for view-only mode * view-only: add tests * view-only: galaxykit collection upload, to ensure there's a collection both describes need it * test/README: mention cypress.env.json.template, document `settings` and `restart` * view-only: actually go to namespace detail and wait for namespace detail title * github cypress settings.py: turn off collections approval (GALAXY_REQUIRE_CONTENT_APPROVAL) GALAXY_REQUIRE_CONTENT_APPROVAL=True is the default, and causes collections added by `galaxykit collection upload` to only appear in Approvals UI, where they need to be approved first before appearing (AAH-628 is open for approval tests) * test/README: also document `containers` in `cypress.env.json`, from #1142 (cherry picked from commit fb0a8d0) Co-authored-by: Martin Hradil <mhradil@redhat.com>

himdel force-pushed the cypress-settings branch from 070c13c to 7467ad9 Compare October 12, 2021 16:25

himdel mentioned this pull request Oct 14, 2021

collection upload - use urljoin to prevent double slash ansible/galaxykit#14

Merged

himdel force-pushed the cypress-settings branch from e1b3c5c to ccdac03 Compare October 14, 2021 02:15

This was referenced Oct 19, 2021

Tests for EE Use in Controller #1113

Merged

Cypress helpers for local & remote EE, changing settings #1116

Merged

himdel added 2 commits October 29, 2021 23:01

view-only: simple test for view-only mode

2ebe961

view-only: add tests

ae2a934

himdel force-pushed the cypress-settings branch from ccdac03 to ba5fc13 Compare October 29, 2021 23:07

himdel marked this pull request as ready for review October 29, 2021 23:08

himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 29, 2021

himdel requested a review from ZitaNemeckova October 29, 2021 23:12

himdel changed the title ~~Cypress: modify settings.py when needed; add view-only test~~ Cypress: add view-only tests Oct 29, 2021

patchback bot mentioned this pull request Oct 29, 2021

[PR #1116/84ef1f96 backport][stable-4.4] Cypress helpers for local & remote EE, changing settings #1146

Merged

himdel force-pushed the cypress-settings branch from d4c0cbc to 00b0ac0 Compare October 30, 2021 00:55

himdel added 4 commits October 30, 2021 01:19

view-only: galaxykit collection upload, to ensure there's a collection

df90728

both describes need it

test/README: mention cypress.env.json.template, document settings a…

4051042

…nd `restart`

view-only: actually go to namespace detail

28ea43f

and wait for namespace detail title

himdel force-pushed the cypress-settings branch from eef815d to 29db1a4 Compare October 30, 2021 01:25

This was referenced Oct 30, 2021

cypress test delete collection version #1117

Merged

Delete entire collection cypress test #1137

Merged

Tests for all screens, actions, forms and features himdel/ansible-hub-ui#1

Closed

test/README: also document containers in cypress.env.json, from a…

365bd5f

…nsible#1142

himdel mentioned this pull request Oct 30, 2021

Fix cy.addLocalContainer on github actions #1142

Merged

ZitaNemeckova approved these changes Nov 1, 2021

View reviewed changes

himdel merged commit fb0a8d0 into ansible:master Nov 1, 2021

himdel deleted the cypress-settings branch November 1, 2021 14:44

patchback bot mentioned this pull request Nov 1, 2021

[PR #1082/fb0a8d09 backport][stable-4.4] Cypress: add view-only tests #1186

Merged

github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Nov 1, 2021

patchback bot mentioned this pull request Nov 3, 2021

[PR #1142/ad376a95 backport][stable-4.4] Fix cy.addLocalContainer on github actions #1190

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cypress: add view-only tests #1082

Cypress: add view-only tests #1082

himdel commented Oct 12, 2021 •

edited

himdel commented Oct 14, 2021 •

edited

ZitaNemeckova left a comment

patchback bot commented Nov 1, 2021 •

edited

Cypress: add view-only tests #1082

Cypress: add view-only tests #1082

Conversation

himdel commented Oct 12, 2021 • edited

himdel commented Oct 14, 2021 • edited

ZitaNemeckova left a comment

Choose a reason for hiding this comment

patchback bot commented Nov 1, 2021 • edited

Backport to stable-4.4: 💚 backport PR created

himdel commented Oct 12, 2021 •

edited

himdel commented Oct 14, 2021 •

edited

patchback bot commented Nov 1, 2021 •

edited