Fix cy.addLocalContainer on github actions

[himdel]

Follow-up to #1116, which adds the helper

Successful run using the container: https://github.com/ansible/ansible-hub-ui/runs/4053371839?check_suite_focus=true (had an extra commit with a version of the test being added in #1141)

Without this, the command fails on podman push for 2 reasons:

• needs podman login first
• pushing to localhost:5001 works in dev, but not with pulp-oci-images, and vice versa
  • => switching to configurable localhost:8002 on pulp-oci-images while keeping localhost:5001 in cypress.env.json.template

This also switches from running one shell to run 3 commands, to running 4 commands separately in a row, to better catch error codes and stdout/stderr of each command. This should mean better error messages if something breaks again.

Should unblock: #1113, #1141

---

❕ Note: when testing locally, most likely you first need to add "containers": "localhost:5001" to your test/cypress.env.json (see test/cypress.env.json.template) (documented in #1082, to prevent conflicts)

[ZitaNemeckova]

No luck with podman for me. BUT it works for me with docker :)

So here's my changes that worked for me

diff --git a/test/cypress/support/commands.js b/test/cypress/support/commands.js
index 81935c07..f0eed4d2 100644
--- a/test/cypress/support/commands.js
+++ b/test/cypress/support/commands.js
@@ -546,24 +546,24 @@ Cypress.Commands.add(
     const server = Cypress.env('containers');
 
     return cy
-      .exec(shell`podman pull ${registry + remoteName}`)
+      .exec(shell`docker pull ${registry + remoteName}`)
       .then(log, logFail)
       .then(() =>
         cy.exec(
-          shell`podman image tag ${remoteName} ${server}/${localName}:latest`,
+          shell`docker image tag ${remoteName} ${server}/${localName}:latest`,
         ),
       )
       .then(log, logFail)
       .then(() =>
         cy.exec(
-          shell`podman login ${server} --tls-verify=false --username=admin --password=admin`,
+          shell`docker login ${server} --tls-verify=false --username=admin --password=admin`,
           { failOnNonZeroExit: false },
         ),
       )
       .then(log, logFail)
       .then(() =>
         cy.exec(
-          shell`podman push ${server}/${localName}:latest --tls-verify=false`,
+          shell`docker push ${server}/${localName}:latest`,
           { failOnNonZeroExit: false },
         ),
       )

[ShaiahWren]

LGTM

[ZitaNemeckova]

Let's merge it and anyone with local problems will switch to docker if needed.

[patchback]

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/ad376a9550c74369a042a3517c079766eaf9f4c6/pr-1142

Backported as #1190

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.