Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: Update translated strings #1187

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

Spredzy
Copy link
Contributor

@Spredzy Spredzy commented Nov 2, 2021

Signed-off-by: Christian M. Adams chadams@redhat.com

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Nov 2, 2021
locale/fr.po Outdated Show resolved Hide resolved
@himdel
Copy link
Collaborator

himdel commented Nov 2, 2021

$ git st ; git cherry-pick ba68129b39ed6a31e5d38e89ae90d4149cbb03f5 20d148aa1ec3e07aff598a4b0adaf43c9298f02b
## pr1187
...

$ npm run lint:po

> ansible-hub-ui@0.1.0 lint:po /home/himdel/ansible-hub-ui
> for f in locale/*po; do locale/lint.pl "$f" 2>&1 | sed 's/<>/'"$(basename "$f")"'/' ; done

Difference between msgid="<0>Note:</0> Use this URL to configure ansible-galaxy to upload collections to this namespace. More information on ansible-galaxy configurations can be found <1>here</1>." and msgstr="<0>Remarque:</0> Utilisez cette URL pour configurer ansible-galaxy afin de télécharger des collections dans cet espace de noms. Vous trouverez plus d'informations sur les configurations d'ansible-galaxy ici.":
  Missing from msgstr: <1> </1>
  at locale/lint.pl line 32, fr.po line 42.

Difference between msgid="<0>{username}</0> will be removed from <1>{groupname}</1>." and msgstr="<0>{username}</0> sera retiré de {groupname}.":
  Missing from msgstr: <1> </1>
  at locale/lint.pl line 32, fr.po line 62.

Difference between msgid="Indexing failed for {name}" and msgstr="L'indexation a échoué pour {nom}":
  Missing from msgstr: {name}
  Unexpected in msgstr: {nom}
  at locale/lint.pl line 32, fr.po line 1124.

@Spredzy

locale/fr.po Outdated Show resolved Hide resolved
locale/fr.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linter is green 👍

@himdel himdel merged commit 483ec6f into ansible:master Nov 2, 2021
@patchback
Copy link

patchback bot commented Nov 2, 2021

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/483ec6fbdc2ceb9703f606d74297d4c8961373d3/pr-1187

Backported as #1189

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: Christian M. Adams <chadams@redhat.com>
(cherry picked from commit 483ec6f)
himdel pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: Christian M. Adams <chadams@redhat.com>
(cherry picked from commit 483ec6f)

Co-authored-by: Yanis Guenane <yguenane@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Nov 2, 2021
ZitaNemeckova added a commit to ZitaNemeckova/ansible-hub-ui that referenced this pull request Nov 8, 2021
This fixes issue with incorrect translation of some strings that looklike this  "string {0} string"
ZitaNemeckova added a commit to ZitaNemeckova/ansible-hub-ui that referenced this pull request Nov 8, 2021
@himdel himdel mentioned this pull request Jan 11, 2022
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Mar 27, 2022
    git checkout upstream/stable-4.4 locale/*po
    npm run gettext:extract ; npm run gettext:compile

master translations were last updated in ansible#1187, except for periodic re-extracts
4.4 locales were last updated in ansible#1769, newer :)

so, taking the update to master, and re-extracting (& merging) from there
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Mar 27, 2022
    git checkout upstream/stable-4.4 locale/*po
    npm run gettext:extract ; npm run gettext:compile

master translations were last updated in ansible#1187, except for periodic re-extracts
4.4 locales were last updated in ansible#1769, newer :)

so, taking the update to master, and re-extracting (& merging) from there

No-Issue
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 4, 2022
    git checkout upstream/stable-4.4 locale/*po
    npm run gettext:extract ; npm run gettext:compile

master translations were last updated in ansible#1187, except for periodic re-extracts
4.4 locales were last updated in ansible#1769, newer :)

so, taking the update to master, and re-extracting (& merging) from there

No-Issue
himdel added a commit that referenced this pull request Apr 4, 2022
git checkout upstream/stable-4.4 locale/*po
    npm run gettext:extract ; npm run gettext:compile

master translations were last updated in #1187, except for periodic re-extracts
4.4 locales were last updated in #1769, newer :)

so, taking the update to master, and re-extracting (& merging) from there

No-Issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants