webpack.base: update for new frontend component config - bundlePfModules and htmlPlugin.inject #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2021
himdel
added
backport-4.3
himdel
commented
Dec 7, 2021
…les and htmlPlugin.inject Replaces ansible#1188 As of `@redhat-cloud-services/frontend-components-config` 4.5.0+, patternfly is removed from the build so as not to clash with other patternfly versions in cloud. This is not desirable for standalone/standalone-keycloak => disabling for non-insights builds. But the option only affects `config.resolve.alias`, which we override in `webpack-ts-overrides.js`. So merging the overrides together with base so we can merge the config properly and get both sets of aliases. As of `@redhat-cloud-services/frontend-components-config` 4.5.4+, htmlPlugin is configured to not inject js & css to html by default. This is not desirable for standalone/standalone-keycloak => setting inject:true for non-insights builds.
…ting for App.$BUILD_HASH.js
between `@redhat-cloud-services/frontend-components-config` 4.5.6 and 4.5.8, the js output filename changed from `js/App.(hash).js` to `js/App.(timestamp).(hash).js` that breaks BUILD_HASH, setting it to the timestamp, but expecting the timestamp to be the whole string .. and failing fixing to set BUILD_HASH to both timestamp and hash
|
Ah, this only passed cypress before updating from 4.5.6 to 4.5.8 :)... So...
It should go green this time @ZitaNemeckova :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1188
As of
@redhat-cloud-services/frontend-components-config4.5.0+, patternfly is removed from the build so as not to clash with other patternfly versions in cloud.This is not desirable for standalone/standalone-keycloak => disabling for non-insights builds.
But the option only affects
config.resolve.alias, which we override inwebpack-ts-overrides.js.So merging the overrides together with base so we can merge the config properly and get both sets of aliases.
As of
@redhat-cloud-services/frontend-components-config4.5.4+,HtmlWebpackPluginis configured to not inject js & css to html by default.This is not desirable for standalone/standalone-keycloak => setting inject to true for non-insights builds.
Also added a couple of FIXME comments with things we may want to resolve for cloud config, while things still work without it :)
Cc @ZitaNemeckova , we may want to consider merging with #920. (Or #1373.)