Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4.4] Bump @redhat-cloud-services/frontend-components-config from 4.3.9 to 4.5.8 #1367

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2021

Bumps @redhat-cloud-services/frontend-components-config from 4.3.9 to 4.5.8.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 13, 2021
@himdel
Copy link
Collaborator

himdel commented Dec 13, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stable-4.4/redhat-cloud-services/frontend-components-config-4.5.8 branch from 201c59d to 2060e8b Compare December 13, 2021 15:30
@himdel
Copy link
Collaborator

himdel commented Dec 13, 2021

#1341 (comment)

=> needs #1342

@himdel
Copy link
Collaborator

himdel commented Dec 31, 2021

@dependabot rebase

Bumps [@redhat-cloud-services/frontend-components-config](https://github.com/RedHatInsights/frontend-components) from 4.3.9 to 4.5.8.
- [Release notes](https://github.com/RedHatInsights/frontend-components/releases)
- [Commits](https://github.com/RedHatInsights/frontend-components/commits)

---
updated-dependencies:
- dependency-name: "@redhat-cloud-services/frontend-components-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stable-4.4/redhat-cloud-services/frontend-components-config-4.5.8 branch from 2060e8b to 5c1a71f Compare December 31, 2021 01:37
…les and htmlPlugin.inject

As of `@redhat-cloud-services/frontend-components-config` 4.5.0+, patternfly is removed from the build so as not to clash with other patternfly versions in cloud.
This is not desirable for standalone/standalone-keycloak => disabling for non-insights builds.
But the option only affects `config.resolve.alias`, which we override in `webpack-ts-overrides.js`.
So merging the overrides together with base so we can merge the config properly and get both sets of aliases.

As of `@redhat-cloud-services/frontend-components-config` 4.5.4+, htmlPlugin is configured to not inject js & css to html by default.
This is not desirable for standalone/standalone-keycloak => setting inject:true for non-insights builds.

(cherry picked from commit 2901719)
…ting for App.$BUILD_HASH.js

(cherry picked from commit a089024)
between `@redhat-cloud-services/frontend-components-config` 4.5.6 and 4.5.8, the js output filename changed from `js/App.(hash).js` to `js/App.(timestamp).(hash).js`

that breaks BUILD_HASH, setting it to the timestamp, but expecting the timestamp to be the whole string .. and failing

fixing to set BUILD_HASH to both timestamp and hash

(cherry picked from commit a77f005)
@himdel himdel merged commit 7808341 into stable-4.4 Jan 6, 2022
@himdel himdel deleted the dependabot/npm_and_yarn/stable-4.4/redhat-cloud-services/frontend-components-config-4.5.8 branch January 6, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant