eslintrc: enable more default rules #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/home/himdel/ansible-hub-ui/src/components/execution-environment/publish-to-controller-modal.tsx
353:75 error `'` can be escaped with `'`, `‘`, `&ansible#39;`, `’` react/no-unescaped-entities
/home/himdel/ansible-hub-ui/src/components/repositories/remote-form.tsx
252:71 error `'` can be escaped with `'`, `‘`, `&ansible#39;`, `’` react/no-unescaped-entities
/home/himdel/ansible-hub-ui/src/containers/execution-environment-detail/tag-manifest-modal.tsx
222:19 error `'` can be escaped with `'`, `‘`, `&ansible#39;`, `’` react/no-unescaped-entities
/home/himdel/ansible-hub-ui/src/containers/namespace-detail/namespace-detail.tsx
492:30 error `'` can be escaped with `'`, `‘`, `&ansible#39;`, `’` react/no-unescaped-entities
/home/himdel/ansible-hub-ui/src/containers/token/token-insights.tsx
92:60 error `'` can be escaped with `'`, `‘`, `&ansible#39;`, `’` react/no-unescaped-entities
177:34 error `'` can be escaped with `'`, `‘`, `&ansible#39;`, `’` react/no-unescaped-entities
/home/himdel/ansible-hub-ui/src/containers/execution-environment-detail/base.tsx
45:10 error Component definition is missing display name react/display-name
…ypress/plugins/ disabling in those 2 locations because both have valid uses of `require` (at least while on node 14)
this is a warning, not an error, so it doesn't cause red prs => fixing the easy cases, but leaving some for now
/home/himdel/ansible-hub-ui/src/components/execution-environment/publish-to-controller-modal.tsx
210:13 error Missing "key" prop for element in iterator react/jsx-key
/home/himdel/ansible-hub-ui/src/containers/execution-environment-detail/execution_environment_detail_images.tsx
520:15 error Missing "key" prop for element in iterator react/jsx-key
/home/himdel/ansible-hub-ui/src/containers/execution-environment/registry-list.tsx
398:7 error Missing "key" prop for element in array react/jsx-key
/home/himdel/ansible-hub-ui/src/containers/task-management/task_detail.tsx
223:33 error Missing "key" prop for element in iterator react/jsx-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling these default rules:
@typescript-eslint/no-explicit-any,@typescript-eslint/no-var-requires,react/display-name,react/jsx-key,react/no-unescaped-entitiesno-explicit-anywarns about 25 more uses ofany, but those shouldn't make PRs go red (https://github.com/ansible/ansible-hub-ui/runs/4698268100?check_suite_focus=true#step:4:92), and can be fixed separately