Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts: fix lingui:extract blowing up on Unexpected token function #1594

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Feb 2, 2022

Running npm run gettext:extract:

#: src/containers/namespace-detail/namespace-detail.tsx:158
Cannot process file /home/himdel/ansible-hub-ui/src/index.d.ts: Unexpected token (45:25)

  43 |       identifyApp: (s: string) => void;
  44 |       init: () => void;
> 45 |       on: (s: string, f: function) => void;
    |                          ^
  46 |     };
  47 |   };
  48 | }

(it doesn't fail with a non-zero exit status code either :( )

This was casued by #1463 , looks like function is not supported everywhere, () => void works.

    #: src/containers/namespace-detail/namespace-detail.tsx:158
    Cannot process file /home/himdel/ansible-hub-ui/src/index.d.ts: Unexpected token (45:25)

      43 |       identifyApp: (s: string) => void;
      44 |       init: () => void;
    > 45 |       on: (s: string, f: function) => void;
        |                          ^
      46 |     };
      47 |   };
      48 | }

No-Issue
@himdel himdel merged commit 99810ef into ansible:master Feb 4, 2022
@himdel himdel deleted the fix-extract branch February 4, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants