Types some of the any types and ignores rest #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brumik
force-pushed
the
brumik-any-fixes
branch
from
fe1f790
to
9ed5a51
Compare
brumik
force-pushed
the
brumik-any-fixes
branch
from
9ed5a51
to
e93031f
Compare
brumik
force-pushed
the
brumik-any-fixes
branch
from
e93031f
to
c52002c
Compare
|
The others could be typed too probably, but my understanding of the product is too low for it. And I set a 40 min time-frame on this to not to waste time. |
himdel
approved these changes
Jan 11, 2022
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jan 13, 2022
Follow-up to ansible#1493 editors can't seem to handle some of the typing bits, leading to `Property 'meta' does not exist on type 'never'.ts(2339)`, turns out `Promise<never>` is superfluous here, removing and also seeing Argument of type '(result: AxiosResponse<any>) => void' is not assignable to parameter of type '(value: AxiosResponse<any>) => AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'. Type 'void' is not assignable to type 'AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'.ts(2345) => changing `http` type back to `any`.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jan 13, 2022
Follow-up to ansible#1493 editors can't seem to handle some of the typing bits, leading to `Property 'meta' does not exist on type 'never'.ts(2339)`, turns out `Promise<never>` is superfluous here, removing and also seeing Argument of type '(result: AxiosResponse<any>) => void' is not assignable to parameter of type '(value: AxiosResponse<any>) => AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'. Type 'void' is not assignable to type 'AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'.ts(2345) => changing `http` type back to `any`. No-issue
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jan 13, 2022
Follow-up to ansible#1493 editors can't seem to handle some of the typing bits, leading to `Property 'meta' does not exist on type 'never'.ts(2339)`, turns out `Promise<never>` is superfluous here, removing and also seeing Argument of type '(result: AxiosResponse<any>) => void' is not assignable to parameter of type '(value: AxiosResponse<any>) => AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'. Type 'void' is not assignable to type 'AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'.ts(2345) => changing `http` type back to `any`. No-issue
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jan 13, 2022
Follow-up to ansible#1493 editors can't seem to handle some of the typing bits, leading to `Property 'meta' does not exist on type 'never'.ts(2339)`, turns out `Promise<never>` is superfluous here, removing and also seeing Argument of type '(result: AxiosResponse<any>) => void' is not assignable to parameter of type '(value: AxiosResponse<any>) => AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'. Type 'void' is not assignable to type 'AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'.ts(2345) => changing `http` type back to `any`. No-Issue
himdel
added a commit
that referenced
this pull request
Jan 13, 2022
Follow-up to #1493 editors can't seem to handle some of the typing bits, leading to `Property 'meta' does not exist on type 'never'.ts(2339)`, turns out `Promise<never>` is superfluous here, removing and also seeing Argument of type '(result: AxiosResponse<any>) => void' is not assignable to parameter of type '(value: AxiosResponse<any>) => AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'. Type 'void' is not assignable to type 'AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'.ts(2345) => changing `http` type back to `any`. No-Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves upon #1465 with adding some easily type-able types