Fix typescript errors related to never and axios
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
ts-errros
branch
2 times, most recently
from
3ce6cde
to
89fb099
Compare
Follow-up to ansible#1493 editors can't seem to handle some of the typing bits, leading to `Property 'meta' does not exist on type 'never'.ts(2339)`, turns out `Promise<never>` is superfluous here, removing and also seeing Argument of type '(result: AxiosResponse<any>) => void' is not assignable to parameter of type '(value: AxiosResponse<any>) => AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'. Type 'void' is not assignable to type 'AxiosResponse<any> | PromiseLike<AxiosResponse<any>>'.ts(2345) => changing `http` type back to `any`. No-Issue
ShaiahWren
approved these changes
Jan 13, 2022
|
Ah, good to hear that :) cypress.. |
|
Yup, now we're back to the usual sporadic failure, Milan is fixing that :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1493
editors can't seem to handle some of the typing bits, leading to
Property 'meta' does not exist on type 'never'.ts(2339),turns out
Promise<never>is superfluous here, removing :)and also seeing
=> changing
httptype back toany.Cc @ShaiahWren does this help? :)