AboutModal, html comment: show UI git commit hash #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this provides the build-time git commit hash info to the UI No-Issue
himdel
force-pushed
the
ui-commit-hash
branch
from
d44a5e4
to
e4a2e72
Compare
|
(webpack-config fail expected.. this is adding a new |
|
Merging to test insights mode in today's stage deploy. EDIT: Updated insights screenshot above :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
git rev-parse HEADat build time to get the current git commit hash, and provide it as aUI_COMMIT_HASHconfig.Then, in standalone mode, the About modal now has a new "UI Version" entry, and there's a html comment as well..
And in insights mode, there is a new html comment with the version, near the end...
$('.hub-ui-version')in the browser console should find it in either mode :)