AboutModal: show galaxy_ng_commit when available #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since AAH-1360, ansible/galaxy_ng#1191, the api returns the galaxy_ng_commit field, based on GIT_COMMIT at runtime (won't actually do anything now because the var is only added in crc build) No-Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since AAH-1360, ansible/galaxy_ng#1191, the api returns the galaxy_ng_commit field,
based on GIT_COMMIT at runtime
since #1559, the UI is displaying the ui commit in AboutModal.
So, making sure we can display both, when available.
Won't actually do anything now because the var is only added in crc build, aka the place without about modal..
but if it did: