-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Signing 2] Add sign badge to collection card #1628
Conversation
brumik
commented
Feb 9, 2022
If this PR is fine, I'll update the tests (they rely on a selector which is not there anymore) |
@brumik There are two modes to display collections and in the second one (a list one) there's no sign label. Is that on purpose? (The icons to change the view are to the left of the top pagination.) |
@ZitaNemeckova I did not realized it, I think it should have some sign notifications there too. @trahman73 any mockups for this or can I go as I feel would be right following the conventions of the namespace page? |
@brumik Good catch, we can follow the pattern from the Namespaces area here. Thanks! |
@ZitaNemeckova In the Namespaces PR here: |
^ Seems like we get inconsitent card sizing now, and title and company don't get cut off with ellipsis. Is that something you can fix, or should we just add the badge to the existing cards without changing how they work? |
replaces ansible#1628 this just adds the signature badge to collection card
I think we can replace this by #1763 , looks like adding SignatureBadge to the existing CardHeader works fine by itself :) |
replaces ansible#1628 this just adds the signature badge to collection card
I probably just missed a PF prop on the card. But your PR seems smaller, we can roll with that. Closing in favour of #1763 |
* CollectionCard: add SignatureBadge replaces #1628 this just adds the signature badge to collection card * ComponentCard - add left margin for signature badge useful when a logo is too wide No-Issue