Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Signing 2] Collection and namespace signing #1629

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[Signing 2] Collection and namespace signing #1629

merged 2 commits into from
Mar 30, 2022

Conversation

brumik
Copy link
Contributor

@brumik brumik commented Feb 9, 2022

Screenshot from 2022-02-09 13-05-33
Screenshot from 2022-02-09 13-05-26
Screenshot from 2022-02-09 13-05-10
Screenshot from 2022-02-09 13-05-00

@brumik brumik requested a review from himdel February 9, 2022 12:06
@brumik
Copy link
Contributor Author

brumik commented Feb 9, 2022

I'll rebase this when #1624 is merged.

@brumik brumik mentioned this pull request Feb 9, 2022
Closed
2 tasks
@trahman73
Copy link

This is minor, but the signed styling on the version dropdown itself is like below... same gray color test as the "Last updated..." message.
image

This helps to further separate the (latest) from the signed text.

@brumik
Copy link
Contributor Author

brumik commented Feb 10, 2022

@trahman73 I never seen a design like this. The latest is the part of the dropdown item, but the Signed does not seem like it. Can you provide an example of an expanded dropdown please?

@trahman73
Copy link

@brumik Here is the full dropdown...

image

If we can't do the above styling to the PF component, then this one will work... I just combined...

(Latest) (Signed) to (Latest, Signed)

image

@brumik brumik changed the title [Signing 2] Collection and namespace signing [Signing 2] Collection and namespace signing [WAIT FOR API] Mar 2, 2022
@brumik brumik changed the title [Signing 2] Collection and namespace signing [WAIT FOR API] [Signing 2] Collection and namespace signing Mar 3, 2022
@brumik brumik mentioned this pull request Mar 3, 2022
Closed
@brumik brumik requested a review from himdel March 25, 2022 11:41
@himdel
Copy link
Collaborator

himdel commented Mar 28, 2022

(Rebasing should fix the tests (#1827))

himdel
himdel approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I wasn't able to sign - canSign returned false as there's no sign_collections_on_namespace permission now, but that looks like it's being addressed in #1801

@himdel
Copy link
Collaborator

himdel commented Mar 30, 2022

Ah, @brumik is on PTO, all the view-only parts seem to be working, the non-working things are not visible, merging to unblock work on the rest.

@himdel himdel merged commit 4e04e49 into ansible:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brumik @trahman73 @himdel