Reimplement unamed-task rule as name[missing]

This reimplementation will allow us to implement closely related
extra checks.

Related: #2171 #2170 #2169 #2036

examples/playbooks/task-has-name-failure.yml

@@ -1,9 +1,11 @@
 ---
 - hosts: all
   tasks:
-    - ansible.builtin.command: echo "no name"
-    - name:
+    - ansible.builtin.command: echo "no name" # <-- 1
+      changed_when: false
+    - name: "" # <-- 2
       ansible.builtin.command: echo "empty name"
-    - ansible.builtin.debug:
+      changed_when: false
+    - ansible.builtin.debug: # <-- 3
         msg: Debug without a name
-    - ansible.builtin.meta: flush_handlers
+    - ansible.builtin.meta: flush_handlers # <-- 4

src/ansiblelint/constants.py

@@ -100,6 +100,7 @@ def main():
     "704": "meta-video-links",
     "911": "syntax-check",
     "var-spacing": "jinja[spacing]",
+    "unnamed-task": "name[missing]",
 }
 
 PLAYBOOK_TASK_KEYWORDS = [

src/ansiblelint/data/profiles.yml

@@ -36,7 +36,7 @@ basic:
     partial-become:
     playbook-extension:
     role-name:
-    unnamed-task:
+    name:
     var-naming:
     yaml:
 moderate:

src/ansiblelint/rules/name.py

@@ -0,0 +1,58 @@
+"""Implementation of NameRule."""
+import sys
+from typing import TYPE_CHECKING, Any, Dict, Union
+
+from ansiblelint.errors import MatchError
+from ansiblelint.rules import AnsibleLintRule
+
+if TYPE_CHECKING:
+    from typing import Optional
+
+    from ansiblelint.file_utils import Lintable
+
+
+class NameRule(AnsibleLintRule):
+    """All tasks should be named."""
+
+    id = "name"
+    description = (
+        "All tasks should have a distinct name for readability "
+        "and for ``--start-at-task`` to work"
+    )
+    severity = "MEDIUM"
+    tags = ["idiom"]
+    version_added = "historic"
+
+    def matchtask(
+        self, task: Dict[str, Any], file: "Optional[Lintable]" = None
+    ) -> Union[bool, str, MatchError]:
+        if not task.get("name"):
+            return self.create_matcherror(
+                linenumber=task["__line__"], tag="name[missing]", filename=file
+            )
+        return False
+
+
+if "pytest" in sys.modules:  # noqa: C901
+
+    from ansiblelint.rules import RulesCollection
+
+    # from ansiblelint.rules.name import NameRule
+    from ansiblelint.runner import Runner
+
+    def test_file_positive() -> None:
+        """Positive test for unnamed-task."""
+        collection = RulesCollection()
+        collection.register(NameRule())
+        success = "examples/playbooks/task-has-name-success.yml"
+        good_runner = Runner(success, rules=collection)
+        assert [] == good_runner.run()
+
+    def test_file_negative() -> None:
+        """Negative test for unnamed-task."""
+        collection = RulesCollection()
+        collection.register(NameRule())
+        failure = "examples/playbooks/task-has-name-failure.yml"
+        bad_runner = Runner(failure, rules=collection)
+        errs = bad_runner.run()
+        assert len(errs) == 4

test/test_import_playbook.py

@@ -14,5 +14,5 @@ def test_task_hook_import_playbook(default_rules_collection: RulesCollection) ->
     assert len(results) == 2
     # Assures we detected the issues from imported playbook
     assert "Commands should not change things" in results_text
-    assert "unnamed-task" in results_text
+    assert "[name]" in results_text
     assert "All tasks should be named" in results_text

test/test_skip_inside_yaml.py

@@ -103,7 +103,8 @@ def test_role_tasks(default_text_runner: RunFromText) -> None:
     results = default_text_runner.run_role_tasks_main(ROLE_TASKS)
     assert len(results) == 1, results
     assert results[0].linenumber == 2
-    assert results[0].rule.id == "unnamed-task"
+    assert results[0].tag == "name[missing]"
+    assert results[0].rule.id == "name"
 
 
 def test_role_tasks_with_block(default_text_runner: RunFromText) -> None:

test/test_skiputils.py

@@ -150,19 +150,19 @@ def test_playbook_noqa(default_text_runner: RunFromText) -> None:
                                             "__file__": Path(
                                                 "examples/playbooks/noqa-nested.yml"
                                             ),
-                                            "skipped_rules": ["unnamed-task"],
+                                            "skipped_rules": ["name[missing]"],
                                         }
                                     ],
                                     "__line__": 6,
                                     "__file__": Path(
                                         "examples/playbooks/noqa-nested.yml"
                                     ),
-                                    "skipped_rules": ["unnamed-task"],
+                                    "skipped_rules": ["name[missing]"],
                                 }
                             ],
                             "__line__": 4,
                             "__file__": Path("examples/playbooks/noqa-nested.yml"),
-                            "skipped_rules": ["unnamed-task"],
+                            "skipped_rules": ["name[missing]"],
                         }
                     ],
                     "__line__": 2,

tox.ini

@@ -126,7 +126,7 @@ deps =
 setenv =
   PIP_CONSTRAINT = {toxinidir}/requirements.txt
 commands =
-  sh -c "rm -f docs/pkg/*.rst"
+  sh -c "rm -f {toxinidir}/docs/pkg/*.rst"
   {envpython} -m sphinx \
     -j auto \
     -b linkcheck \