Add recommendations for coding styles #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cidrblock |
This was referenced May 23, 2022
Closed
jillr
changed the title
branic
approved these changes
May 24, 2022
thedoubl3j
approved these changes
May 24, 2022
NilashishC
reviewed
May 25, 2022
ssbarnea
approved these changes
May 25, 2022
ganeshrn
reviewed
May 25, 2022
ganeshrn
reviewed
May 25, 2022
sean-m-sullivan
approved these changes
May 25, 2022
priyamsahoo
approved these changes
May 29, 2022
justjais
approved these changes
May 31, 2022
ericzolf
requested changes
Jun 1, 2022
There was a problem hiding this comment.
Again good inputs, more formal comments than regarding the content.
Overall we're trying to align this section (and the roles one) to the overall pattern explanation/rationale/example, so if you could start to stick to it, that would be helpful, but on the other hand, the coding recommendations are generally very short so it's a lot of boilerplate...
Regarding the task names, I really hate having them start with a capital letter (only my play names start with a capital letter), but we can discuss this in the group.
tima
reviewed
Jun 6, 2022
mophahr
requested changes
Jun 16, 2022
mophahr
approved these changes
Jun 22, 2022
bontreger
approved these changes
Jun 22, 2022
ericzolf
approved these changes
Jun 27, 2022
|
Approved in CoP meeting 2022-06-29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of coding styles recommendations from ansible eng