Check ANSIBLE_ROLES_PATH before basedir #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'roles' doesn't seem an adequate toplevel name when testing three directories depth. Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
Fix behavior when ANSIBLE_ROLES_PATH is defined, for example:
cd test/roles/test-role
ANSIBLE_ROLES_PATH=.. ansible-lint molecule/default/include-import-role.yml
Fix ansible/molecule#1723
Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
pilou-
changed the title
|
I will push the 3rd commit (the bugfix) once the Travis build result is available (failure expected). |
pilou-
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
ANSIBLE_ROLES_PATHdirectories beforebasedir.The two commands below should report the same output:
cd test && ansible-lint roles/test-rolecd test/roles/test-role && ANSIBLE_ROLES_PATH=.. ansible-lint molecule/default/include-import-role.yml(this is the waymoleculecallsansible-lint)but only the first checks tasks inside the
test-rolerole.This regression has been introduced by 88e9114 which have been included in
v4.0.0a0.Unit test included.
Fix ansible/molecule#1723.