Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with_filetree loop: reduce false positive #582

Merged
merged 2 commits into from
Dec 4, 2019
Merged

with_filetree loop: reduce false positive #582

merged 2 commits into from
Dec 4, 2019

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Oct 1, 2019 •
edited
Loading

handle with_filetree loop:

  • don't return an error when a string ending with a slash is used
  • with_filetree loop accepts list too
  • add tests

@pilou- pilou- force-pushed the with_filetree_decrease_false_positive branch 2 times, most recently from 054221c to fca6a70 Compare October 1, 2019 13:40
@pilou-
with_filetree loop: add tests
fca6a70 
Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
@pilou-
with_filetree loop: decrease false positive
cff78ca 
don't report an error when a path ending with a slash or a variable are
used

Signed-off-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
@pilou- pilou- changed the title [WIP] with_filetree loop: reduce false positive with_filetree loop: reduce false positive Oct 9, 2019
bristea
bristea approved these changes Oct 23, 2019
View reviewed changes
Copy link

@bristea bristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and apparently it was added to ansible long time ago.

@awcrosby awcrosby mentioned this pull request Dec 4, 2019
Closed
@awcrosby awcrosby closed this Dec 4, 2019
@awcrosby awcrosby reopened this Dec 4, 2019
@awcrosby awcrosby merged commit d7c0dad into ansible:master Dec 4, 2019
@awcrosby
Copy link
Contributor

awcrosby commented Dec 4, 2019

LGTM, closes #494

@awcrosby awcrosby mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@bristea bristea bristea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pilou- @awcrosby @ssbarnea @bristea