Enable ansible-lint to auto-detect roles/playbooks #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Nov 1, 2019
webknjaz
reviewed
Nov 1, 2019
webknjaz
reviewed
Nov 1, 2019
webknjaz
reviewed
Nov 1, 2019
webknjaz
reviewed
Nov 1, 2019
webknjaz
reviewed
Nov 1, 2019
webknjaz
reviewed
Nov 1, 2019
|
@webknjaz Please have another look on it, I hope I addressed all concerns. If you want to see the output of calling it on multiple repositories, look at https://sbarnea.com/tmp/result.html -- i kinda scripted its execution in order to get an idea about what to expect in real-life once the code goes in. |
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
webknjaz
reviewed
Nov 2, 2019
|
This pull request introduces 1 alert when merging 212a85e into 5453d07 - view on LGTM.com new alerts:
|
webknjaz
reviewed
Nov 3, 2019
webknjaz
reviewed
Nov 3, 2019
|
This pull request introduces 1 alert when merging ace361e into cad1804 - view on LGTM.com new alerts:
|
webknjaz
reviewed
Nov 4, 2019
When called without any arguments, ansible-lint will now try to look for all playbooks and roles inside current git repository. Unrecognized YAML files will be displayed in verbose mode but will not be considered errors. This will allow users to enable ansible-lint on any repository without being forced to alter the way is called or its configuration each time a new playbooks/role is added. Fixes: #613 Fixes: #564 Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
|
Anything else preventing this to be merged? |
webknjaz
reviewed
Dec 30, 2019
| options = {} | ||
|
|
||
| # git is preferred as it also considers .gitignore | ||
| files = OrderedDict.fromkeys(sorted(subprocess.check_output( |
There was a problem hiding this comment.
@ssbarnea why did you use OrderedDict and not a list here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called without any arguments, ansible-lint will now try to look
for all playbooks and roles inside current git repository.
Unrecognized YAML files will be displayed in verbose mode but will not
be considered errors. This will allow users to enable ansible-lint
on any repository without being forced to alter the way is called or
its configuration each time a new playbooks/role is added.
Fixes: #613
Fixes: #564