Work around virtualenv bug (six) #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging de1f094 into 5765765 - view on LGTM.com new alerts:
|
This fixes #683 six bug which is only another side-effect of the weird packaging implementation changes made to ansible-lint in its more recent history. This change aims to address these issues by implementing proven working packaging practices, while removing custom hacks. We will still need to do some follow-ups to remove implementation code from __init__.py which is a known source of problems. This patch avoided that in order to minimize changes. Fixes: #683 Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
|
This pull request introduces 1 alert when merging a23c89c into 5765765 - view on LGTM.com new alerts:
|
LukeShortCloud
approved these changes
Feb 28, 2020
|
Fixed upstream (pypa/virtualenv#1688). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #683 six bug which is only another side-effect of the weird packaging implementation changes made to ansible-lint in its more recent history.
This change aims to address these issues by implementing proven working packaging practices, while removing custom hacks.
Fixes: #683