Fix MatchError comparison fallback implementation
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code wrongly raised NotImplementedError but the correct way is to return the NotImplemented singleton instead. This is a bugfix for the broken implementation introduced in #881. Ref: https://docs.python.org/3/reference/datamodel.html#object.__lt__
webknjaz
force-pushed
the
bugfixes/match-error-comparison-proto
branch
from
9b25fa2
to
6d1aa10
Compare
ssbarnea
approved these changes
Jul 14, 2020
webknjaz
changed the title
MatchError comparison fallback implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code wrongly
raisedNotImplementedErrorbut thecorrect way is to
returntheNotImplementedsingleton instead.This is a bugfix for the broken implementation introduced in #881.
Ref: https://docs.python.org/3/reference/datamodel.html#object.__lt__