Adding notifications for ec2_asg module

[shawnsi]

Copied from ansible/ansible#9066

Issue Type:

Feature Idea

Ansible Version:

1.8

Environment:

N/A

Summary:

AWS autoscale groups support notifications when changes occur (instance is terminated, instance is launched, etc) as per http://docs.aws.amazon.com/AutoScaling/latest/DeveloperGuide/ASGettingNotifications.html
. Are their plans to add this functionality to the ec2_asg module? If not I can add it and submit a pull request. If this is already being done then I will leave it be. I tried searching pull requests and issues and couldn't find anything concerning this.

The way I would want it to work is as follows:

if state is present and notifications is true then apply notifications.

if state is absent and notifications is false then disable notifications prior to actually deleting the asg. This way one will not get spammed with alerts. This would work well for me as ec2_asg is being used as part of our deploy process and I would want alerts to be silenced during deploys.

Steps To Reproduce:

N/A

Expected Results:

N/A

Actual Results:

N/A

[shawnsi]

Attached is a first attempt to implement notifications. I've tested it successfully against ansible 1.9.1 with an existing autoscaling workflow.

[robynbergeron]

Hi @shawnsi -- thanks for submitting this feature idea (relabeled it from being a feature PR, since you just submitted the PR in #2273.)

@garethr -- Pinging you to bring this feature request to your attention. Please note that you are under no particular obligation to add this feature. Also: There is a PR for it, as noted above and where I just pinged you to let you know -- so hopefully this helps out! :)

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help