Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Adding SNS notification support to ec2_asg module #2273

Closed
wants to merge 1 commit into from

Conversation

shawnsi
Copy link
Contributor

@shawnsi shawnsi commented Oct 14, 2015

Addresses #1844

@robynbergeron
Copy link

Hi @shawnsi -- thanks for this PR, and the accompanying feature request issue (#1844).

@garethr -- Please review this PR to make sure it adheres to the following guidelines:

http://docs.ansible.com/developing_modules.html#module-checklist

If it passes these guidelines, and if you believe it’s a good PR otherwise, please add a comment with "shipit" in the text, and we will flag it for inclusion.

If it fails these guidelines, please add a comment with "needs_revision" in the text, along with the needed changes, and we will flag it for revision.

@robynbergeron
Copy link

(Also, OMG @garethr, HAI! ☀️)

@shawnsi
Copy link
Contributor Author

shawnsi commented Dec 2, 2015

@robynbergeron Anything I can do to help move the review process along?

@gregdek
Copy link
Contributor

gregdek commented Mar 22, 2016

Thanks @shawnsi for this PR. This module is maintained by the Ansible core team, so it can take a while for patches to be reviewed. Thanks for your patience.

@shawnsi
Copy link
Contributor Author

shawnsi commented Sep 8, 2016

@gregdek can a core reviewer look at this? I think its a pretty straight forward update for AWS API compatibility.

@gregdek
Copy link
Contributor

gregdek commented Sep 9, 2016

@shawnsi I'd recommend attending one of the Ansible Core team meetings on IRC:

https://github.com/ansible/community/blob/master/MEETINGS.md

@shawnsi
Copy link
Contributor Author

shawnsi commented Sep 9, 2016

@gregdek Ok. I don't really understand why a PR isn't sufficient for this but I'll pop in to the next one that fits my schedule.

@gregdek
Copy link
Contributor

gregdek commented Sep 9, 2016

@shawnsi apologies. There are hundreds of PRs, and it can be challenging to prioritize.

@ryansb
Copy link
Contributor

ryansb commented Sep 16, 2016

Merged as a29fb59

@ryansb ryansb closed this Sep 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants