This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
[v2] cloudstack fixes #1322
Merged
[v2] cloudstack fixes #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @resmo. Marking for inclusion. |
|
can you squash the commits? |
- cs_affinitygroup: add project support Project support in CloudStack for affinity groups is going to be fixed/implemented in the near future, this module should already support. - cs_affinitygroup: fix missing returns in doc - cs_volume: fix disk offering not found - cs_volume: fix volume not found if created with display_volume=no - cs_firewall: argument zone is missing, default zone is always used. credits for reporting and fixing to @atsaki closes #1320 - cs_instance: fix user_data base64 encoding fails if not a string
|
@bcoca squashed. |
|
I did not realize cs_volume is 2.1, had to remove it from the backport to stable-2.0 to be able to apply the fixes to the other modules. |
|
oh. my fault sorry. next time I make 2 PR. one for devel and one for stable-2.0 |
|
no worries, just informing you because the commits don't look the same and the attribution might be messed up |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has target devel but these fixes are meant to be for v2 as well. Let me know if you need a separate PR into stable-2.0 branch.