add datadog_downtime module (try 3)

[stefanweller]

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

datadog_downtime

ANSIBLE VERSION

2.0.2.0

SUMMARY

Third try to bring datadog_downtime module to Ansible. Now with improved idempotency checking.

[gregdek]

Thanks @stefanweller for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion.

[This message brought to you by your friendly Ansibull-bot.]

[stefanweller]

@gregdek Sorry, but had to remove the other fork due to rebasing problems.

[stefanweller]

@skornehl Please review again. THX

[stefanweller]

ready_for_review
works_for_me
passes_guidelines

[skornehl]

shipit

[goekhanm]

Awesome @stefanweller THX!!
shipit !!
Our Opera-Team will love this module!

[skornehl]

@gregdek Does Ansibull-bot ignore this PR or is anything missing?

[gregdek]

The bot doesn't pick up new modules; they need to be approved manually. Putting this on the next new modules agenda.

[alikins]

mismatch appears unused

[gundalow]

needs_revision - docs updates

[alikins]

misc flake8 stuff (nothing blocking a merge, but for reference)

monitoring/datadog_downtime.py:139:0: F401 'sys' imported but unused
monitoring/datadog_downtime.py:149:0: E302 expected 2 blank lines, found 1
monitoring/datadog_downtime.py:185:0: E302 expected 2 blank lines, found 1
monitoring/datadog_downtime.py:247:0: E302 expected 2 blank lines, found 1
monitoring/datadog_downtime.py:274:0: E302 expected 2 blank lines, found 1
monitoring/datadog_downtime.py:283:0: E302 expected 2 blank lines, found 1
monitoring/datadog_downtime.py:194:0: E115 expected an indented block (comment)
monitoring/datadog_downtime.py:227:12: E265 block comment should start with '# '
monitoring/datadog_downtime.py:231:12: E265 block comment should start with '# '
monitoring/datadog_downtime.py:197:12: F841 local variable 'mismatch' is assigned to but never used
monitoring/datadog_downtime.py:236:20: F405 time may be undefined, or defined from star imports: ansible.module_utils.basic, ansible.module_utils.urls
monitoring/datadog_downtime.py:255:23: F405 time may be undefined, or defined from star imports: ansible.module_utils.basic, ansible.module_utils.urls
monitoring/datadog_downtime.py:212:73: E203 whitespace before ':'
monitoring/datadog_downtime.py:200:81: E203 whitespace before ':'
monitoring/datadog_downtime.py:204:89: E203 whitespace before ':'
monitoring/datadog_downtime.py:208:101: E203 whitespace before ':'

[mattclay]

This comment should be indented to match the block it is in.

[ansibot]

This repository has been locked. All new issues and pullrequests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pullrequest to the ansible/ansible repo.

[ansibot]

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.