Standing Agenda, New Modules Meeting

[gregdek]

This is the standing agenda for New Module review.

PLEASE DO NOT ADD YOUR MODULE TO THIS AGENDA YOURSELF. This meeting is only for final review of modules that have already been reviewed by other community members, and only Ansible team members should be adding modules to this list.

[MichaelBaydoun]

ec2 virtual private gateway module: ansible/ansible-modules-extras#1709 looks ready to merge (shipped)

[gregdek]

ansible/ansible-modules-extras#1775 (needs_review, 6 July)

[gundalow]

ansible/ansible-modules-extras#1862 looks ready to merge (only one shipit, but it's good)

(nope, failing travis, needs to be rebased --gdk)

[Spredzy]

ansible/ansible-modules-extras#2326

[gregdek]

ansible/ansible-modules-extras#2442

[gregdek]

ansible/ansible-modules-extras#2271

[gregdek]

ansible/ansible-modules-extras#2208

[gregdek]

ansible/ansible-modules-extras#1901

[gregdek]

ansible/ansible-modules-extras#1775

[ryansb]

ansible/ansible-modules-extras#2558

[gregdek]

ansible/ansible-modules-extras#662 (asking for functionality to be moved into s3_bucket instead)

[gregdek]

ansible/ansible-modules-extras#1765 (being reviewed by gundalow)

[gregdek]

ansible/ansible-modules-extras#2381 (needs_revision)

[gregdek]

ansible/ansible-modules-extras#1023 Merged

[tima]

ansible/ansible-modules-extras#1902 Merged

[gregdek]

ansible/ansible-modules-extras#1730 Merged

[abadger]

1902 and 1730 reviewed and marked needs_revision in the tickets. 1902 is much closer to being ready than 1730.

[gregdek]

ansible/ansible-modules-extras#2305 Closed

[gregdek]

ansible/ansible-modules-extras#2329 Merged

[tima]

A module PR for review, but not a new one....

ansible/ansible-modules-core#4054

[tima]

Came across this one that looks ready for core review again...

ansible/ansible-modules-extras#2521 Merged

[tima]

ansible/ansible-modules-extras#2305

[ryansb]

ansible/ansible-modules-extras#2829 Merged

[gregdek]

ansible/ansible-modules-core#4469 Merged

[gregdek]

ansible/ansible-modules-extras#2917

[gregdek]

@mikeoutland added this long list --

ansible/ansible-modules-extras#2977
ansible/ansible-modules-extras#2978
ansible/ansible-modules-extras#2979
ansible/ansible-modules-extras#2981
ansible/ansible-modules-extras#2982
ansible/ansible-modules-extras#2983
ansible/ansible-modules-extras#2984
ansible/ansible-modules-extras#2985

...was this on the advice of anyone here? Because this is a lot of modules, and all were added in the past day.

[mikeoutland]

@gregdek is this a question for me? ^^

[gregdek]

@mikeoutland This agenda is intended for final review of modules that have already been vetted by community members. There are occasional exceptions and Ansible team members will ask someone to submit directly, which is what I'm asking, from you or from anyone on the @ansible/core team.

We're not having this meeting for a few weeks anyway because 2.2 is frozen.

[ryansb]

ansible/ansible-modules-extras#2917 discussed, some nonblocking comments added.

[shaharmor]

There are 2 new modules for AWS:
Application ELB: ansible/ansible-modules-extras#2946
Target group: ansible/ansible-modules-extras#2947

There are more updates to those PRs here as well:
https://github.com/wimnat/ansible-modules-extras/pull/3
https://github.com/wimnat/ansible-modules-extras/pull/4

They are working, but there are a few bugs still (that I have fixed locally).

My question is what is the correct way to go with this in order for them to get merged into ansible?

1. Should i wait for all those PRs to get all their fixes ready
2. Create a new PR myself with all the fixes in other PRs + my fixes instead?

Also, I think the naming of the new modules is not good and suggest to rename them to:
ec2_elb_application & ec2_target_group instead.

Discussed in meeting 2016-11-09

• New PR for fixes will allow ownership to be tracked
• @ryansb has offered to help with the review

[Spredzy]

ansible/ansible-modules-extras#2341

[wimnat]

@shaharmor

Also, I think the naming of the new modules is not good and suggest to rename them to:
ec2_elb_application & ec2_target_group instead.

I disagree with the above statement.

The module naming should follow boto3 api naming where possible. ELB API is not part of EC2 hence why they are named differently. I think the current ELB module ec2_elb_lb should also be renamed.

[gundalow]

The New Modules meetings have been rolled into the existing "Public Core Meetings"

Please see https://github.com/ansible/community/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Ameeting_agenda%20 for those agenda tickets

and https://github.com/ansible/community/blob/master/MEETINGS.md for a link to the .ics file that you can import by URL to your calendar.