Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to src/-layout #551

Closed
webknjaz opened this issue Aug 31, 2021 · 0 comments · Fixed by #562
Closed

Migrate to src/-layout #551

webknjaz opened this issue Aug 31, 2021 · 0 comments · Fixed by #562
Labels
enhancement New feature or request structural Structural changes needed in code base

Comments

@webknjaz
Copy link
Member

ISSUE TYPE
  • Feature Idea
SUMMARY

The current repository is structured to have ansible_navigator/ in the project root. This is considered problematic because it may make testing scenarios run checks against the git checkout contents rather than the package "as installed" on the end-user systems (because, depending on the Python invocation, the current working dir may be prepended to sys.path shadowing the imports). It may potentially also mask problems with parts of the content not getting into the distribution packages.

Refs:
@webknjaz webknjaz added enhancement New feature or request new New issues and PRs to triaged structural Structural changes needed in code base labels Aug 31, 2021
ssbarnea added a commit that referenced this issue Sep 1, 2021
@ssbarnea
Adopt src code layout
87cbd5d 
Fixes: #551
@ssbarnea ssbarnea mentioned this issue Sep 1, 2021
Merged
ssbarnea added a commit that referenced this issue Sep 1, 2021
@ssbarnea
Adopt src code layout
5248d7f 
Fixes: #551
ssbarnea added a commit that referenced this issue Sep 1, 2021
@ssbarnea
Adopt src code layout
403ff35 
Also ensures that .tox/.doctrees tmp location is used instead of
.tmp/.doctrees which was not a gitignored location and also
polluted the root project directory.

Fixes: #551
ssbarnea added a commit that referenced this issue Sep 2, 2021
@ssbarnea
Adopt src code layout
05483d3 
Also ensures that .tox/.doctrees tmp location is used instead of
.tmp/.doctrees which was not a gitignored location and also
polluted the root project directory.

Fixes: #551
ssbarnea added a commit that referenced this issue Sep 2, 2021
@ssbarnea
Adopt src code layout
82a4cce 
Fixes: #551
ansible-zuul bot pushed a commit that referenced this issue Sep 2, 2021
@ssbarnea
Adopt src code layout (#562)
745e3a4 
Adopt src code layout

Fixes: #551

Reviewed-by: Ganesh Nalawade <None>
Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: None <None>
Spredzy pushed a commit to Spredzy/ansible-navigator that referenced this issue Oct 6, 2021
@ssbarnea @Spredzy
Adopt src code layout (ansible#562)
b83ecc5 
Adopt src code layout

Fixes: ansible#551

Reviewed-by: Ganesh Nalawade <None>
Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: None <None>
(cherry picked from commit 745e3a4)
@webknjaz webknjaz removed the new New issues and PRs to triaged label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request structural Structural changes needed in code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adopt src code layout ansible/ansible-navigator
1 participant
@webknjaz