Adopt src code layout #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/stuff
branch
2 times, most recently
from
5248d7f
to
403ff35
Compare
ganeshrn
approved these changes
Sep 2, 2021
|
/cc @cidrblock Can you please review this PR |
webknjaz
suggested changes
Sep 2, 2021
Fixes: #551
cidrblock
approved these changes
Sep 2, 2021
webknjaz
approved these changes
Sep 2, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
FTR we probably need to notify the current RPM spec maintainers about the structural changes. OTOH with #557, it should be easier for them to pick up a well-tested upstream spec. |
relrod
added a commit
to relrod/winston
that referenced
this pull request
Sep 17, 2021
Change: - ansible#562 broke people who run navigator from a clone of the repository without installing it somewhere. The search path for the share directory starts with looking for it relative to utils.py for exactly this scenario. However when the ansible_navigator directory got moved a level deeper, this path wasn't updated. Test Plan: - Ran ansible-navigator from git clone after pip uninstalling it. Signed-off-by: Rick Elrod <rick@elrod.me>
relrod
added a commit
to relrod/winston
that referenced
this pull request
Sep 17, 2021
Change: - ansible#562 broke people who run navigator from a clone of the repository without installing it somewhere. The search path for the share directory starts with looking for it relative to utils.py for exactly this scenario. However when the ansible_navigator directory got moved a level deeper, this path wasn't updated. Test Plan: - Ran ansible-navigator from git clone after pip uninstalling it. Signed-off-by: Rick Elrod <rick@elrod.me>
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
[utils] Fix share dir when running from repo clone Change: #562 broke people who run navigator from a clone of the repository without installing it somewhere. The search path for the share directory starts with looking for it relative to utils.py for exactly this scenario. However when the ansible_navigator directory got moved a level deeper, this path wasn't updated. Test Plan: Ran ansible-navigator from git clone after pip uninstalling it. Signed-off-by: Rick Elrod rick@elrod.me Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None>
Spredzy
pushed a commit
to Spredzy/ansible-navigator
that referenced
this pull request
Oct 6, 2021
Adopt src code layout Fixes: ansible#551 Reviewed-by: Ganesh Nalawade <None> Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: Bradley A. Thornton <bthornto@redhat.com> Reviewed-by: None <None> (cherry picked from commit 745e3a4)
Spredzy
pushed a commit
to Spredzy/ansible-navigator
that referenced
this pull request
Oct 6, 2021
[utils] Fix share dir when running from repo clone Change: ansible#562 broke people who run navigator from a clone of the repository without installing it somewhere. The search path for the share directory starts with looking for it relative to utils.py for exactly this scenario. However when the ansible_navigator directory got moved a level deeper, this path wasn't updated. Test Plan: Ran ansible-navigator from git clone after pip uninstalling it. Signed-off-by: Rick Elrod rick@elrod.me Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None> (cherry picked from commit 16939d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #551