[utils] Fix share dir when running from repo clone #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: - ansible#562 broke people who run navigator from a clone of the repository without installing it somewhere. The search path for the share directory starts with looking for it relative to utils.py for exactly this scenario. However when the ansible_navigator directory got moved a level deeper, this path wasn't updated. Test Plan: - Ran ansible-navigator from git clone after pip uninstalling it. Signed-off-by: Rick Elrod <rick@elrod.me>
relrod
added a commit
to relrod/winston
that referenced
this pull request
Sep 17, 2021
Change: - It was impossible to run ansible-navigator or ansible-lint or some other things from within src/ansible_navigator due to the conflicting yaml.py filename. This is just a simple rename since yaml is a commonly used library. Test Plan: - Ran ansible-navigator locally (with change from ansible#575) Signed-off-by: Rick Elrod <rick@elrod.me>
webknjaz
approved these changes
Sep 17, 2021
|
recheck |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
[yaml] Rename yaml to _yaml to prevent conflicts Change: It was impossible to run ansible-navigator or ansible-lint or some other things from within src/ansible_navigator due to the conflicting yaml.py filename. This is just a simple rename since yaml is a commonly used library. Test Plan: Ran ansible-navigator locally (with change from #575) Signed-off-by: Rick Elrod rick@elrod.me Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None>
Spredzy
pushed a commit
to Spredzy/ansible-navigator
that referenced
this pull request
Oct 6, 2021
[utils] Fix share dir when running from repo clone Change: ansible#562 broke people who run navigator from a clone of the repository without installing it somewhere. The search path for the share directory starts with looking for it relative to utils.py for exactly this scenario. However when the ansible_navigator directory got moved a level deeper, this path wasn't updated. Test Plan: Ran ansible-navigator from git clone after pip uninstalling it. Signed-off-by: Rick Elrod rick@elrod.me Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None> (cherry picked from commit 16939d2)
Spredzy
pushed a commit
to Spredzy/ansible-navigator
that referenced
this pull request
Oct 6, 2021
[yaml] Rename yaml to _yaml to prevent conflicts Change: It was impossible to run ansible-navigator or ansible-lint or some other things from within src/ansible_navigator due to the conflicting yaml.py filename. This is just a simple rename since yaml is a commonly used library. Test Plan: Ran ansible-navigator locally (with change from ansible#575) Signed-off-by: Rick Elrod rick@elrod.me Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None> (cherry picked from commit 0918b3c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
without installing it somewhere. The search path for the share
directory starts with looking for it relative to utils.py for exactly
this scenario. However when the ansible_navigator directory got moved
a level deeper, this path wasn't updated.
Test Plan:
Signed-off-by: Rick Elrod rick@elrod.me