Create ansible-runner:stable-2.9-devel images #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull-request updated, HEAD is now f9c0c8a |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
0cf62ec
to
f9c0c8a
Compare
|
Pull-request updated, HEAD is now 571a350 |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
f9c0c8a
to
571a350
Compare
|
Pull-request updated, HEAD is now e1b8a4a |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
571a350
to
e1b8a4a
Compare
pabelanger
changed the title
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
e1b8a4a
to
bffd5fc
Compare
|
Pull-request updated, HEAD is now bffd5fc |
|
Pull-request updated, HEAD is now f9cf6b2 |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
bffd5fc
to
f9cf6b2
Compare
|
Pull-request updated, HEAD is now d38f551 |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
f9cf6b2
to
d38f551
Compare
pabelanger
commented
Dec 16, 2020
Comment on lines
+7
to
+11
| RUN if [ "$ANSIBLE_BRANCH" != "" ] ; then \ | ||
| echo "Installing requirements.txt / upper-constraints.txt for Ansible $ANSIBLE_BRANCH" ; \ | ||
| cp /tmp/src/tools/requirements-$ANSIBLE_BRANCH.txt /tmp/src/requirements.txt ; \ | ||
| cp /tmp/src/tools/upper-constraints-$ANSIBLE_BRANCH.txt /tmp/src/upper-constraints.txt ; \ | ||
| fi |
There was a problem hiding this comment.
So we need to do this, because of ansible / ansible-base / ansible-core pypi naming. For stable-2.9, we need to use ansible. But for stable-2.10, I think we ship ansible-base, then once we release stable-2.11, it is ansible-core.
So confusing!
|
Pull-request updated, HEAD is now 3631990 |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
d38f551
to
3631990
Compare
|
Pull-request updated, HEAD is now 923618c |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
3631990
to
923618c
Compare
|
recheck |
|
Pull-request updated, HEAD is now b815311 |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
923618c
to
b815311
Compare
This will allow us to create stable-2.9 ansible-runner images. This works by using the constraints system in pip to cap our ansible version that we install. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
|
Pull-request updated, HEAD is now dffdf6e |
pabelanger
force-pushed
the
temp/stable-2.9-image
branch
from
b815311
to
dffdf6e
Compare
pabelanger
changed the title
AlanCoding
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to create stable-2.9 ansible-runner images. This
works by using the constraints system in pip to cap our ansible version
that we install.
Signed-off-by: Paul Belanger pabelanger@redhat.com